Issue 1396973004: Fix bug in Uri.removeFragment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396973004: Fix bug in Uri.removeFragment. (Closed)

Created:
5 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 2 months ago

Reviewers:
asgerf, Søren Gjesse, floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix bug in Uri.removeFragment. It used the external getters for the existing port and query, which are non-null even when the port or query are absent. This introduced a new default-valued/empty part. Also reordered declarations to have fields > constructors > rest. Fixes issue #24593 BUG= http://dartbug.com/24593 R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/a8e3eb4e101e914a47ac3a188fbbc214cc206595

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -206 lines)			Patch
	M	sdk/lib/core/uri.dart	View		12 chunks	+217 lines, -201 lines	0 comments	Download
	M	tests/corelib/uri_test.dart	View		1 chunk	+17 lines, -5 lines	0 comments	Download

Total messages: 6 (2 generated)

Lasse Reichstein Nielsen

5 years, 2 months ago (2015-10-15 10:42:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8e3eb4e101e914a47ac3a188fbbc214cc206595 (presubmit successful).