Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1396943002: win: stub of end-to-end test (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@locks
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: stub of end-to-end test I'd like to write some `expect(1)`-style tests (possibly using http://pexpect.readthedocs.org/en/stable/) to verify that various windbg commands that I'm adding support for do actually work when consuming minidumps in real life. For the moment, this is just the beginnings of a stub as I don't know if bots even have windbg/cdb installed. R=mark@chromium.org BUG=crashpad:20, crashpad:46, crashpad:52 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fd40ebbc7252f07fe86d233c17796e0d428f2020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M build/run_tests.py View 1 chunk +9 lines, -0 lines 0 comments Download
A snapshot/win/end_to_end_test.py View 1 chunk +68 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (0 generated)
scottmg
5 years, 2 months ago (2015-10-08 21:29:42 UTC) #1
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-09 03:55:54 UTC) #2
scottmg
Committed patchset #1 (id:1) manually as fd40ebbc7252f07fe86d233c17796e0d428f2020 (presubmit successful).
5 years, 2 months ago (2015-10-09 04:09:45 UTC) #3
scottmg
5 years, 2 months ago (2015-10-09 04:15:49 UTC) #4
Message was sent while issue was closed.
Darn
https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x86_wow64_...

cdb_path: None

I'll see if I can figure out a way to auto or manual install it tomorrow.

Powered by Google App Engine
This is Rietveld 408576698