Autofill: Replace "save credit card" infobar with a bubble (Views only).

chrome/browser/ui/views/location_bar/save_credit_card_icon_view.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/location_bar/save_credit_card_icon_view.h"
+
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/view_ids.h"
+#include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
+#include "chrome/grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/gfx/color_palette.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/gfx/vector_icons_public.h"
+
+SaveCreditCardIconView::SaveCreditCardIconView(CommandUpdater* command_updater,
+                                               Browser* browser)
+    : BubbleIconView(command_updater, IDC_SAVE_CREDIT_CARD_FOR_PAGE),
+      browser_(browser) {
+  set_id(VIEW_ID_SAVE_CREDIT_CARD_BUTTON);
+  SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_SAVE_CREDIT_CARD));
+  SetToggled(false);
+}
+
+SaveCreditCardIconView::~SaveCreditCardIconView() {}
+
+void SaveCreditCardIconView::SetToggled(bool on) {
+  SetImage(gfx::CreateVectorIcon(gfx::VectorIconId::AUTOFILL, 16,
+                                 on ? gfx::kGoogleBlue : gfx::kChromeIconGrey));
+}
+
+void SaveCreditCardIconView::OnExecuting(
+    BubbleIconView::ExecuteSource execute_source) {}
+
+views::BubbleDelegateView* SaveCreditCardIconView::GetBubble() const {
+  if (!browser_)

[hcarmona, 2015/10/16 21:16:35]

Why allow browser to be nullptr if that means you can't get the bubble?

[bondd, 2015/10/22 02:15:17]

SaveCreditCardIconView is instantiated in the LocationBarView constructor with
the rest of the location bar icons. It's possible for browser to be null there
so I have to handle it here. I suppose I could just not create the icon if
browser is null, but none of the other icons do it that way and I'd like to keep
things as consistent as possible.

+    return nullptr;
+  content::WebContents* web_contents =
+      browser_->tab_strip_model()->GetActiveWebContents();
+  if (!web_contents)
+    return nullptr;
+  autofill::SaveCardBubbleControllerImpl* controller =
+      autofill::SaveCardBubbleControllerImpl::FromWebContents(web_contents);
+  if (!controller)
+    return nullptr;
+
+  return static_cast<autofill::SaveCardBubbleViews*>(
+      controller->save_card_bubble_view());
+}