Autofill: Replace "save credit card" infobar with a bubble (Views only).

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
@@ skipping 168 matching lines @@
 
 void LocationBarViewMac::UpdateManagePasswordsIconAndBubble() {
   WebContents* web_contents = GetWebContents();
   if (!web_contents)
     return;
   ManagePasswordsUIController::FromWebContents(web_contents)
       ->UpdateIconAndBubbleState(manage_passwords_decoration_->icon());
   OnDecorationsChanged();
 }
 
+void LocationBarViewMac::UpdateSaveCreditCardIcon() {
+  // Not implemented on Mac.

[sky, 2015/10/26 20:56:26]

NOTIMPLEMENTED

[bondd, 2015/10/27 01:06:39]

Done. I had originally used a comment to match the surrounding code in
UpdateLocationBarVisibility() and UpdateOpenPDFInReaderPrompt() below. But you
are right, NOTIMPLEMENTED() is better because it actually enforces that the
function is not called. I was about to update the other "not implemented"
locations in this file to use NOTIMPLEMENTED() instead of just a comment, but I
realized that I'm not 100% sure that they are never called. Better to leave them
alone for now, since they're completely unrelated to the rest of this CL.

+}
+
 void LocationBarViewMac::UpdatePageActions() {
   RefreshPageActionDecorations();
   Layout();
 
   [field_ updateMouseTracking];
   [field_ setNeedsDisplay:YES];
 }
 
 void LocationBarViewMac::UpdateBookmarkStarVisibility() {
   star_decoration_->SetVisible(IsStarEnabled());
@@ skipping 516 matching lines @@
 }
 
 bool LocationBarViewMac::UpdateMicSearchDecorationVisibility() {
   bool is_visible = !GetToolbarModel()->input_in_progress() &&
                     browser_->search_model()->voice_search_supported();
   if (mic_search_decoration_->IsVisible() == is_visible)
     return false;
   mic_search_decoration_->SetVisible(is_visible);
   return true;
 }