Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 1396883005: Reland: Enable Wallet metadata sync. (Closed)

Created:
5 years, 2 months ago by please use gerrit instead
Modified:
5 years, 2 months ago
Reviewers:
Nicolas Zea, Evan Stade
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rouslan+autofill_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Enable Wallet metadata sync. Originally landed in https://crrev.com/90c4e947, which enabled a code path where https://crrev.com/6aeb9079 introduced a bug a few hours earlier. The bug was detected in tests, which resulted in a revert. https://crrev.com/7a8e3fdf fixed the bug in the hidden code path. It's safe to reland now. TBR=zea@chromium.org, estade@chromium.org BUG=481595 Committed: https://crrev.com/0b999094d4ce8a462b70327cc38ca117313a1504 Cr-Commit-Position: refs/heads/master@{#353927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396883005/1
5 years, 2 months ago (2015-10-13 22:48:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 00:45:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0b999094d4ce8a462b70327cc38ca117313a1504 Cr-Commit-Position: refs/heads/master@{#353927}
5 years, 2 months ago (2015-10-14 00:46:42 UTC) #4
nednguyen
5 years, 1 month ago (2015-11-13 21:10:49 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1444743002/ by nednguyen@google.com.

The reason for reverting is: Speculative revert to see if this patch regresses
blink_perf.shadow_dom benchmark.

Powered by Google App Engine
This is Rietveld 408576698