Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1396803002: [test] Pull test262 as a dependency. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Pull test262 as a dependency. BUG= Committed: https://crrev.com/2b87016abafc313036895f9d5e87c31eba96e2c5 Cr-Commit-Position: refs/heads/master@{#31182}

Patch Set 1 #

Patch Set 2 : Update readme #

Total comments: 6

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -52 lines) Patch
M .gitignore View 1 chunk +0 lines, -5 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262/README View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M test/test262/testcfg.py View 2 chunks +6 lines, -39 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396803002/1
5 years, 2 months ago (2015-10-08 13:42:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396803002/20001
5 years, 2 months ago (2015-10-08 13:44:15 UTC) #4
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-08 13:44:18 UTC) #6
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1396803002/diff/20001/test/test262/README File test/test262/README (right): https://codereview.chromium.org/1396803002/diff/20001/test/test262/README#newcode7 test/test262/README:7: fetched with 'gclient sync'. To update ...
5 years, 2 months ago (2015-10-08 14:00:06 UTC) #7
Michael Achenbach
https://codereview.chromium.org/1396803002/diff/20001/test/test262/README File test/test262/README (right): https://codereview.chromium.org/1396803002/diff/20001/test/test262/README#newcode7 test/test262/README:7: fetched with 'gclient sync'. To update to a newer ...
5 years, 2 months ago (2015-10-08 14:04:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396803002/40001
5 years, 2 months ago (2015-10-08 14:04:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396803002/40001
5 years, 2 months ago (2015-10-08 14:04:56 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 14:40:41 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 14:40:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b87016abafc313036895f9d5e87c31eba96e2c5
Cr-Commit-Position: refs/heads/master@{#31182}

Powered by Google App Engine
This is Rietveld 408576698