Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: Source/WebKit/chromium/public/WebInbandTextTrackClient.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/public/WebInbandTextTrackClient.h
diff --git a/Source/Platform/chromium/public/WebHyphenator.h b/Source/WebKit/chromium/public/WebInbandTextTrackClient.h
similarity index 69%
copy from Source/Platform/chromium/public/WebHyphenator.h
copy to Source/WebKit/chromium/public/WebInbandTextTrackClient.h
index 86bb1bbf9fd94f0de090a7ef96297da2f23396b8..3cedbe6412ba84ad2591881c64e3e629242ff235 100644
--- a/Source/Platform/chromium/public/WebHyphenator.h
+++ b/Source/WebKit/chromium/public/WebInbandTextTrackClient.h
@@ -28,24 +28,32 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebHyphenator_h
-#define WebHyphenator_h
+#ifndef WebInbandTextTrackClient_h
+#define WebInbandTextTrackClient_h
+
+// TODO(matthewjheaney): still need these?
acolwell GONE FROM CHROMIUM 2013/04/23 06:34:18 No. You shouldn't need these since they aren't ref
Matthew Heaney (Chromium) 2013/04/24 04:32:18 Done.
+namespace WebCore {
+class InbandTextTrackPrivate;
+class InbandTextTrackPrivateClient;
+}
-#include "WebCommon.h"
-#include "WebString.h"
namespace WebKit {
-class WebHyphenator {
-public:
- // Returns whether we can support hyphenation for the given locale.
- virtual bool canHyphenate(const WebString& locale) { return false; }
+class WebString;
- // Returns the last position where we can add a hyphen before the given position.
- virtual size_t computeLastHyphenLocation(const WebUChar* characters, size_t length, size_t beforeIndex, const WebString& locale) { return 0; }
+class WebInbandTextTrackClient {
+ public:
+ virtual ~WebInbandTextTrackClient() {}
-protected:
- ~WebHyphenator() { }
+ // TODO(matthewjheaney): need to know correct type
+ //virtual void addWebVTTCue(WebCore::InbandTextTrackPrivate*,
+ virtual void addWebVTTCue(void*,
acolwell GONE FROM CHROMIUM 2013/04/23 06:34:18 Why do you need this parameter?
Matthew Heaney (Chromium) 2013/04/24 04:32:18 parameter removed
+ double start,
+ double end,
+ const WebString& id,
+ const WebString& content,
+ const WebString& settings) = 0;
};
} // namespace WebKit

Powered by Google App Engine
This is Rietveld 408576698