Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp - Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporate aaron's comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h ('K') | « Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h ('k') | Source/core/core.gypi » ('j') | Source/core/platform/graphics/InbandTextTrackPrivateClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

index 08d1ebccf3f4431cb757904164e00e4ecfa43575..ddfe4f5ccee0e1b016dab404cc7e3f6571969a00 100644

--- a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

+++ b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp

@@ -15,6 +15,7 @@

#include "GraphicsContext3DPrivate.h"

#include "GraphicsLayerChromium.h"

#include "HTMLMediaElement.h"

+#include "InbandTextTrackPrivateImpl.h"

#include "IntSize.h"

#include "KURL.h"

#include "MediaPlayer.h"

@@ -298,6 +299,12 @@ void WebMediaPlayerClientImpl::setWebLayer(WebLayer* layer)

}

+void WebMediaPlayerClientImpl::addTextTrack(WebInbandTextTrack* text_track)

+ m_mediaPlayer->addTextTrack(

+ WTF::adoptRef(new InbandTextTrackPrivateImpl(text_track)));

acolwell GONE FROM CHROMIUM 2013/04/19 17:45:49 nit: You should not need the WTF. If so then somet

Matthew Heaney (Chromium) 2013/04/20 04:19:25 Done.

// MediaPlayerPrivateInterface -------------------------------------------------

void WebMediaPlayerClientImpl::load(const String& url)