Source/WebKit/chromium/public/WebMediaPlayerClient.h - Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/public/WebMediaPlayerClient.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/public/WebInbandTextTrack.h ('K') | « Source/WebKit/chromium/public/WebInbandTextTrackClient.h ('k') | Source/WebKit/chromium/src/InbandTextTrackPrivateImpl.h » ('j') | Source/WebKit/chromium/src/InbandTextTrackPrivateImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/public/WebMediaPlayerClient.h

diff --git a/Source/WebKit/chromium/public/WebMediaPlayerClient.h b/Source/WebKit/chromium/public/WebMediaPlayerClient.h

index f551cacae897640e669ed956506b09fafed373ca..37edb8e7adb9c74ed5553403f66ccfeaab7b14b4 100644

--- a/Source/WebKit/chromium/public/WebMediaPlayerClient.h

+++ b/Source/WebKit/chromium/public/WebMediaPlayerClient.h

@@ -31,6 +31,7 @@

#ifndef WebMediaPlayerClient_h

#define WebMediaPlayerClient_h

+#include "WebInbandTextTrack.h"

acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: remove and forward declare.

Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.

#include "WebMediaPlayer.h"

namespace WebKit {

@@ -83,6 +84,9 @@ public:

virtual void closeHelperPlugin() = 0;

virtual bool needsWebLayerForVideo() const = 0;

virtual void setWebLayer(WebLayer*) = 0;

+ // TODO(matthewjheaney): resolve nature of pointer

acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 Remove comment? I'm assuming you have resolved the

Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.

+ virtual void addTextTrack(WebInbandTextTrack* text_track) = 0;

acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: remove parameter name.

Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.

protected:

~WebMediaPlayerClient() { }

};