Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: Source/WebCore/platform/graphics/GenericCueData.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/platform/graphics/GenericCueData.h
diff --git a/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h b/Source/WebCore/platform/graphics/GenericCueData.h
similarity index 85%
copy from Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h
copy to Source/WebCore/platform/graphics/GenericCueData.h
index 0db04423dc5fa5b862f8579630996730ee34ef3d..7a4941f4bc108aac6a27496ff08ed74da7a92bbe 100644
--- a/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h
+++ b/Source/WebCore/platform/graphics/GenericCueData.h
@@ -23,8 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef InbandTextTrackPrivateClient_h
-#define InbandTextTrackPrivateClient_h
+#ifndef GenericCueData_h
+#define GenericCueData_h
#include "Color.h"
#include <wtf/Noncopyable.h>
@@ -32,8 +32,6 @@
namespace WebCore {
-class InbandTextTrackPrivate;
-
class GenericCueData {
WTF_MAKE_NONCOPYABLE(GenericCueData); WTF_MAKE_FAST_ALLOCATED;
public:
@@ -84,10 +82,12 @@ public:
void setFontName(String fontName) { m_fontName = fontName; }
double baseFontSize() const { return m_baseFontSize; }
- void setBaseFontSize(double baseFontSize) { m_baseFontSize = baseFontSize; }
+ void setBaseFontSize(double baseFontSize) {
+ m_baseFontSize = baseFontSize; }
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: Don't line wrap here. Blink style doesn't enf
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
double relativeFontSize() const { return m_relativeFontSize; }
- void setRelativeFontSize(double relativeFontSize) { m_relativeFontSize = relativeFontSize; }
+ void setRelativeFontSize(double relativeFontSize) {
acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 ditto
Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done.
+ m_relativeFontSize = relativeFontSize; }
Color foregroundColor() const { return m_foregroundColor; }
void setForegroundColor(RGBA32 color) { m_foregroundColor.setRGB(color); }
@@ -111,14 +111,6 @@ private:
Color m_backgroundColor;
};
-class InbandTextTrackPrivateClient {
-public:
- virtual ~InbandTextTrackPrivateClient() { }
-
- virtual void addWebVTTCue(InbandTextTrackPrivate*, double /*start*/, double /*end*/, const String& /*id*/, const String& /*content*/, const String& /*settings*/) = 0;
- virtual void addGenericCue(InbandTextTrackPrivate*, GenericCueData*) = 0;
-};
-
} // namespace WebCore
#endif

Powered by Google App Engine
This is Rietveld 408576698