Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp - Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.cpp

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h ('K') | « Source/WebKit/chromium/src/WebInbandTextTrackClientImpl.h ('k') | Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h » ('j') | Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #include <wtf/ExportMacros.h>

	2 #include <wtf/text/WTFString.h>

	3 #include "InbandTextTrackPrivateClient.h"

	4 #include "WebInbandTextTrackClientImpl.h"

	5 #define WEBKIT_IMPLEMENTATION 1

	6 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"

	7

	8 namespace WebKit {

	9

	10 WebInbandTextTrackClientImpl::WebInbandTextTrackClientImpl(

	11 WebCore::InbandTextTrackPrivateClient* client)

	12 : client_(client) {
	acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: { on its own line and add ASSERT(client); nit: { on its own line and add ASSERT(client); Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done. Show quoted text On 2013/04/17 00:13:56, acolwell wrote: > nit: { on its own line and add ASSERT(client); Done.
	13 }

	14

	15 void WebInbandTextTrackClientImpl::addWebVTTCue(

	16 double start,

	17 double end,

	18 const WebString& id,

	19 const WebString& content,

	20 const WebString& settings) {
	acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 nit: { on its own line. nit: { on its own line. Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done. Show quoted text On 2013/04/17 00:13:56, acolwell wrote: > nit: { on its own line. Done.
	21 // TODO(matthewjheaney): resolve value of first param
	acolwell GONE FROM CHROMIUM 2013/04/17 00:13:56 looks like a pointer to the InbandTextTrackPrivate looks like a pointer to the InbandTextTrackPrivateImpl that created this object needs to be passed here. Matthew Heaney (Chromium) 2013/04/18 23:15:42 Done. Show quoted text On 2013/04/17 00:13:56, acolwell wrote: > looks like a pointer to the InbandTextTrackPrivateImpl that created this object > needs to be passed here. Done.
	22 client_->addWebVTTCue(NULL, start, end, id, content, settings);

	23 }

	24

	25 } // namespace WebKit

OLD	NEW