Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/public/WebMediaPlayerClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebMediaPlayerClient_h
 #define WebMediaPlayerClient_h
 
+#include "WebInbandTextTrack.h"

[acolwell GONE FROM CHROMIUM, 2013/04/17 00:13:56]

nit: remove and forward declare.

[Matthew Heaney (Chromium), 2013/04/18 23:15:42]

Done.

 #include "WebMediaPlayer.h"
 
 namespace WebKit {
 
 class WebFrame;
 class WebLayer;
 class WebMediaSource;
 class WebPlugin;
 class WebRequest;
 class WebURL;
@@ skipping 32 matching lines @@
     virtual void keyAdded(const WebString& keySystem, const WebString& sessionId) = 0;
     virtual void keyError(const WebString& keySystem, const WebString& sessionId, MediaKeyErrorCode, unsigned short systemCode) = 0;
     virtual void keyMessage(const WebString& keySystem, const WebString& sessionId, const unsigned char* message, unsigned messageLength, const WebURL& defaultURL) = 0;
     virtual void keyNeeded(const WebString& keySystem, const WebString& sessionId, const unsigned char* initData, unsigned initDataLength) = 0;
     // The returned pointer is valid until closeHelperPlugin() is called.
     // Returns 0 if the plugin could not be instantiated.
     virtual WebPlugin* createHelperPlugin(const WebString& pluginType, WebFrame*) = 0;
     virtual void closeHelperPlugin() = 0;
     virtual bool needsWebLayerForVideo() const = 0;
     virtual void setWebLayer(WebLayer*) = 0;
+    // TODO(matthewjheaney): resolve nature of pointer

[acolwell GONE FROM CHROMIUM, 2013/04/17 00:13:56]

Remove comment? I'm assuming you have resolved the ownership relationship.

[Matthew Heaney (Chromium), 2013/04/18 23:15:42]

Done.

+    virtual void addTextTrack(WebInbandTextTrack* text_track) = 0;

[acolwell GONE FROM CHROMIUM, 2013/04/17 00:13:56]

nit: remove parameter name.

[Matthew Heaney (Chromium), 2013/04/18 23:15:42]

Done.

+
 protected:
     ~WebMediaPlayerClient() { }
 };
 
 } // namespace WebKit
 
 #endif