Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: mojo/edk/system/channel_endpoint.h

Issue 1396783004: Convert mojo::system::ChannelEndpointClient to use our new refcounting stuff (instead of base's). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/channel.cc ('k') | mojo/edk/system/channel_endpoint.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/channel_endpoint.h
diff --git a/mojo/edk/system/channel_endpoint.h b/mojo/edk/system/channel_endpoint.h
index 387b02c46605649668c257a902312e6d7cad995d..af537e5890153d6ca75424ae9ffd13bca22a8ec4 100644
--- a/mojo/edk/system/channel_endpoint.h
+++ b/mojo/edk/system/channel_endpoint.h
@@ -7,11 +7,11 @@
#include <memory>
-#include "base/memory/ref_counted.h"
#include "mojo/edk/system/channel_endpoint_id.h"
#include "mojo/edk/system/message_in_transit_queue.h"
#include "mojo/edk/system/mutex.h"
#include "mojo/edk/system/ref_counted.h"
+#include "mojo/edk/system/ref_ptr.h"
#include "mojo/public/cpp/system/macros.h"
namespace mojo {
@@ -127,7 +127,8 @@ class ChannelEndpoint final : public RefCountedThreadSafe<ChannelEndpoint> {
// This returns true in the typical case, and false if this endpoint has been
// detached from the channel, in which case the caller should probably call
// its (new) client's |OnDetachFromChannel()|.
- bool ReplaceClient(ChannelEndpointClient* client, unsigned client_port);
+ bool ReplaceClient(RefPtr<ChannelEndpointClient>&& client,
+ unsigned client_port);
// Called before the |ChannelEndpointClient| gives up its reference to this
// object.
@@ -160,11 +161,10 @@ class ChannelEndpoint final : public RefCountedThreadSafe<ChannelEndpoint> {
// in which case |message_queue| should not be null. In that case, this
// endpoint will simply send queued messages upon being attached to a
// |Channel| and immediately detach itself.
- ChannelEndpoint(ChannelEndpointClient* client,
+ ChannelEndpoint(RefPtr<ChannelEndpointClient>&& client,
unsigned client_port,
MessageInTransitQueue* message_queue = nullptr);
- friend class base::RefCountedThreadSafe<ChannelEndpoint>;
~ChannelEndpoint();
bool WriteMessageNoLock(std::unique_ptr<MessageInTransit> message)
@@ -192,10 +192,9 @@ class ChannelEndpoint final : public RefCountedThreadSafe<ChannelEndpoint> {
// |client_| must be valid whenever it is non-null. Before |*client_| gives up
// its reference to this object, it must call |DetachFromClient()|.
- // NOTE: This is a |scoped_refptr<>|, rather than a raw pointer, since the
- // |Channel| needs to keep the |MessagePipe| alive for the "proxy-proxy" case.
- // Possibly we'll be able to eliminate that case when we have full
- // multiprocess support.
+ // NOTE: This is a |RefPtr<>|, rather than a raw pointer, since the |Channel|
+ // needs to keep the client (e.g., |MessagePipe|) alive for the "proxy-proxy"
+ // case.
// WARNING: |ChannelEndpointClient| methods must not be called under |mutex_|.
// Thus to make such a call, a reference must first be taken under |mutex_|
// and the lock released.
@@ -205,7 +204,7 @@ class ChannelEndpoint final : public RefCountedThreadSafe<ChannelEndpoint> {
// WARNING: Beware of interactions with |ReplaceClient()|. By the time the
// call is made, the client may have changed. This must be detected and dealt
// with.
- scoped_refptr<ChannelEndpointClient> client_ MOJO_GUARDED_BY(mutex_);
+ RefPtr<ChannelEndpointClient> client_ MOJO_GUARDED_BY(mutex_);
unsigned client_port_ MOJO_GUARDED_BY(mutex_);
// |channel_| must be valid whenever it is non-null. Before |*channel_| gives
« no previous file with comments | « mojo/edk/system/channel.cc ('k') | mojo/edk/system/channel_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698