Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: mojo/edk/system/incoming_endpoint.h

Issue 1396783004: Convert mojo::system::ChannelEndpointClient to use our new refcounting stuff (instead of base's). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/system/endpoint_relayer_unittest.cc ('k') | mojo/edk/system/incoming_endpoint.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_ 5 #ifndef MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_
6 #define MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_ 6 #define MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "mojo/edk/system/channel_endpoint_client.h" 10 #include "mojo/edk/system/channel_endpoint_client.h"
11 #include "mojo/edk/system/message_in_transit_queue.h" 11 #include "mojo/edk/system/message_in_transit_queue.h"
12 #include "mojo/edk/system/mutex.h" 12 #include "mojo/edk/system/mutex.h"
13 #include "mojo/edk/system/ref_ptr.h" 13 #include "mojo/edk/system/ref_ptr.h"
14 #include "mojo/public/cpp/system/macros.h" 14 #include "mojo/public/cpp/system/macros.h"
15 15
16 struct MojoCreateDataPipeOptions; 16 struct MojoCreateDataPipeOptions;
17 17
18 namespace mojo { 18 namespace mojo {
19 namespace system { 19 namespace system {
20 20
21 class ChannelEndpoint; 21 class ChannelEndpoint;
22 class DataPipe; 22 class DataPipe;
23 class MessagePipe; 23 class MessagePipe;
24 24
25 // This is a simple |ChannelEndpointClient| that only receives messages. It's 25 // This is a simple |ChannelEndpointClient| that only receives messages. It's
26 // used for endpoints that are "received" by |Channel|, but not yet turned into 26 // used for endpoints that are "received" by |Channel|, but not yet turned into
27 // |MessagePipe|s or |DataPipe|s. 27 // |MessagePipe|s or |DataPipe|s.
28 class IncomingEndpoint final : public ChannelEndpointClient { 28 class IncomingEndpoint final : public ChannelEndpointClient {
29 public: 29 public:
30 IncomingEndpoint(); 30 // Note: Use |MakeRefCounted<IncomingEndpoint>()|.
31 31
32 // Must be called before any other method. 32 // Must be called before any other method.
33 RefPtr<ChannelEndpoint> Init() MOJO_NOT_THREAD_SAFE; 33 RefPtr<ChannelEndpoint> Init() MOJO_NOT_THREAD_SAFE;
34 34
35 scoped_refptr<MessagePipe> ConvertToMessagePipe(); 35 RefPtr<MessagePipe> ConvertToMessagePipe();
36 scoped_refptr<DataPipe> ConvertToDataPipeProducer( 36 RefPtr<DataPipe> ConvertToDataPipeProducer(
37 const MojoCreateDataPipeOptions& validated_options, 37 const MojoCreateDataPipeOptions& validated_options,
38 size_t consumer_num_bytes); 38 size_t consumer_num_bytes);
39 scoped_refptr<DataPipe> ConvertToDataPipeConsumer( 39 RefPtr<DataPipe> ConvertToDataPipeConsumer(
40 const MojoCreateDataPipeOptions& validated_options); 40 const MojoCreateDataPipeOptions& validated_options);
41 41
42 // Must be called before destroying this object if |ConvertToMessagePipe()| 42 // Must be called before destroying this object if |ConvertToMessagePipe()|
43 // wasn't called (but |Init()| was). 43 // wasn't called (but |Init()| was).
44 void Close(); 44 void Close();
45 45
46 // |ChannelEndpointClient| methods: 46 // |ChannelEndpointClient| methods:
47 bool OnReadMessage(unsigned port, MessageInTransit* message) override; 47 bool OnReadMessage(unsigned port, MessageInTransit* message) override;
48 void OnDetachFromChannel(unsigned port) override; 48 void OnDetachFromChannel(unsigned port) override;
49 49
50 private: 50 private:
51 FRIEND_MAKE_REF_COUNTED(IncomingEndpoint);
52
53 IncomingEndpoint();
51 ~IncomingEndpoint() override; 54 ~IncomingEndpoint() override;
52 55
53 Mutex mutex_; 56 Mutex mutex_;
54 RefPtr<ChannelEndpoint> endpoint_ MOJO_GUARDED_BY(mutex_); 57 RefPtr<ChannelEndpoint> endpoint_ MOJO_GUARDED_BY(mutex_);
55 MessageInTransitQueue message_queue_ MOJO_GUARDED_BY(mutex_); 58 MessageInTransitQueue message_queue_ MOJO_GUARDED_BY(mutex_);
56 59
57 MOJO_DISALLOW_COPY_AND_ASSIGN(IncomingEndpoint); 60 MOJO_DISALLOW_COPY_AND_ASSIGN(IncomingEndpoint);
58 }; 61 };
59 62
60 } // namespace system 63 } // namespace system
61 } // namespace mojo 64 } // namespace mojo
62 65
63 #endif // MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_ 66 #endif // MOJO_EDK_SYSTEM_INCOMING_ENDPOINT_H_
OLDNEW
« no previous file with comments | « mojo/edk/system/endpoint_relayer_unittest.cc ('k') | mojo/edk/system/incoming_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698