Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1396743005: Use //build_overrides instead of //build/modules for GN builds. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
CC:
jochen (gone - plz use gerrit), brettw, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use //build_overrides instead of //build/modules for GN builds. R=machenbach@chromium.org BUG=chromium:541791 LOG=N Committed: https://crrev.com/dd8206c81a06e216ffbe7ebba4872f150cec859e Cr-Commit-Position: refs/heads/master@{#31246}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (2 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-09 23:28:05 UTC) #1
Dirk Pranke
This patch depends on https://codereview.chromium.org/1397493004 landing first in chromium.
5 years, 2 months ago (2015-10-09 23:28:29 UTC) #2
Michael Achenbach
LGTM https://codereview.chromium.org/1396743005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1396743005/diff/1/BUILD.gn#newcode12 BUILD.gn:12: import("//build_overrides/v8.gni") In order to create a standalone v8 ...
5 years, 2 months ago (2015-10-12 08:19:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1396743005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1396743005/diff/1/BUILD.gn#newcode12 BUILD.gn:12: import("//build_overrides/v8.gni") On 2015/10/12 at 08:19:03, Michael Achenbach wrote: ...
5 years, 2 months ago (2015-10-12 11:03:28 UTC) #5
Dirk Pranke
On 2015/10/12 11:03:28, jochen wrote: > On 2015/10/12 at 08:19:03, Michael Achenbach wrote: > > ...
5 years, 2 months ago (2015-10-13 23:00:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396743005/1
5 years, 2 months ago (2015-10-13 23:01:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:56:24 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:56:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd8206c81a06e216ffbe7ebba4872f150cec859e
Cr-Commit-Position: refs/heads/master@{#31246}

Powered by Google App Engine
This is Rietveld 408576698