Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1396743003: Mark newly added sqrt test as pass/fail on ia32. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark newly added sqrt test as pass/fail on ia32. Some math libraries that use 80-bit precision operations may give a wrong result for sqrt. TBR=whesse@google.com BUG=dartbug.com/24517 Committed: https://github.com/dart-lang/sdk/commit/ed42136acdf2e0da436d849728550e0f71b0c1f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/language/language.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-10-08 18:02:52 UTC) #2
Florian Schneider
Committed patchset #1 (id:1) manually as ed42136acdf2e0da436d849728550e0f71b0c1f1 (presubmit successful).
5 years, 2 months ago (2015-10-08 18:06:56 UTC) #3
Bill Hesse
5 years, 2 months ago (2015-10-08 20:13:04 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698