Issue 1396703002: Tweak update_deps.py to use git

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396703002: Tweak update_deps.py to use git (Closed)

Created:
5 years, 2 months ago by Jacob

Modified:
5 years, 2 months ago

Reviewers:
vsm, rmacnak

CC:
reviews_dartlang.org, ricow1, terry, Alan Knight

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Tweak update_deps.py to use git BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/b2210ae3abbf5283d1dc8d21332d74fefd08a66d

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -22 lines)			Patch
	M	tools/dartium/update_deps.py	View		5 chunks	+21 lines, -22 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

Tested this script and it worked to update dartium deps. Not exactly high quality code ...

5 years, 2 months ago (2015-10-08 00:03:55 UTC) #2

Jacob

Committed patchset #1 (id:1) manually as b2210ae3abbf5283d1dc8d21332d74fefd08a66d (presubmit successful).

5 years, 2 months ago (2015-10-08 00:25:13 UTC) #4

rmacnak

5 years, 2 months ago (2015-10-08 00:40:33 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1396703002/diff/1/tools/dartium/update_deps.py
File tools/dartium/update_deps.py (right):

https://codereview.chromium.org/1396703002/diff/1/tools/dartium/update_deps.p...
tools/dartium/update_deps.py:58: # TODO(jacobr): what is the git repo for
integration if any?
git@github.com:dart-lang/sdk.git@integration

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages