EAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, se…

sdk/lib/mirrors/mirrors.dart

Index: sdk/lib/mirrors/mirrors.dart
===================================================================
--- sdk/lib/mirrors/mirrors.dart	(revision 21177)
+++ sdk/lib/mirrors/mirrors.dart	(working copy)
@@ -174,14 +174,16 @@
 abstract class ObjectMirror implements Mirror {
   /**
    * Invokes the named function and returns a mirror on the result.
+   * The arguments must be InstanceMirrors, numbers, strings 
+   * or booleans.

[ahe, 2013/04/10 05:52:22]

[InstanceMirror], [num], [String], or [bool].

    *
    * TODO(turnidge): Properly document.
    * TODO(turnidge): Handle ambiguous names.
    * TODO(turnidge): Handle optional & named arguments.

[ahe, 2013/04/10 05:52:22]

Remove TODO from documentation, it should just be plain comments.

[gbracha, 2013/04/10 18:01:16]

I will do this for method affected by this CL.  There are other such cases which
should also change, but others have expressed a desire that the CL focus on  one
main purpose, so the others can be changed later.

    */
-  Future<InstanceMirror> invoke(String memberName,
-                                List<Object> positionalArguments,
-                                [Map<String,Object> namedArguments]);
+  Future<InstanceMirror> invokeAsync(String memberName,
+                                     List<Object> positionalArguments,
+                                     [Map<String,Object> namedArguments]);
 
   /**
    * Invokes a getter and returns a mirror on the result. The getter
@@ -190,16 +192,18 @@
    *
    * TODO(turnidge): Handle ambiguous names.
    */
-  Future<InstanceMirror> getField(String fieldName);
+  Future<InstanceMirror> getFieldAsync(String fieldName);
 
   /**
    * Invokes a setter and returns a mirror on the result. The setter
    * may be either the implicit setter for a non-final field or a
    * user-defined setter method.
+   * The argument must be either an InstanceMirror, a number, a string 
+   * or a boolean.
    *
    * TODO(turnidge): Handle ambiguous names.
    */
-  Future<InstanceMirror> setField(String fieldName, Object value);
+  Future<InstanceMirror> setFieldAsync(String fieldName, Object value);
 }
 
 /**
@@ -265,8 +269,8 @@
    *  - the value is of type [bool]
    *  - the value is of type [String]
    */
-  Future<InstanceMirror> apply(List<Object> positionalArguments,
-                               [Map<String,Object> namedArguments]);
+  Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
+                                    [Map<String,Object> namedArguments]);
 
   /**
    * Looks up the value of a name in the scope of the closure. The
@@ -436,12 +440,14 @@
 
   /**
    * Invokes the named constructor and returns a mirror on the result.
+   * The arguments must be InstanceMirrors, numbers, strings 
+   * or booleans.
    *
    * TODO(turnidge): Properly document.
    */
-  Future<InstanceMirror> newInstance(String constructorName,
-                                     List<Object> positionalArguments,
-                                     [Map<String,Object> namedArguments]);
+  Future<InstanceMirror> newInstanceAsync(String constructorName,
+                                          List<Object> positionalArguments,
+                                          [Map<String,Object> namedArguments]);
 
   /**
    * Does this mirror represent a class?