Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 13967003: EAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, se… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 21177)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -139,10 +139,10 @@
abstract class _LocalObjectMirrorImpl extends _LocalVMObjectMirrorImpl
implements ObjectMirror {
_LocalObjectMirrorImpl(ref) : super(ref) {}
-
- Future<InstanceMirror> invoke(String memberName,
- List positionalArguments,
- [Map<String,dynamic> namedArguments]) {
+
+Future<InstanceMirror> invokeAsync(String memberName,
+ List positionalArguments,
+ [Map<String,dynamic> namedArguments]) {
if (namedArguments != null) {
throw new UnimplementedError(
'named argument support is not implemented');
@@ -162,7 +162,7 @@
return completer.future;
}
- Future<InstanceMirror> getField(String fieldName)
+ Future<InstanceMirror> getFieldAsync(String fieldName)
{
ahe 2013/04/10 05:52:22 Open curly brace on previous line
Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
try {
@@ -173,7 +173,7 @@
return completer.future;
}
- Future<InstanceMirror> setField(String fieldName, Object arg)
+ Future<InstanceMirror> setFieldAsync(String fieldName, Object arg)
{
ahe 2013/04/10 05:52:22 Ditto.
_validateArgument(0, arg);
@@ -305,8 +305,8 @@
'ClosureMirror.source is not implemented');
}
- Future<InstanceMirror> apply(List<Object> positionalArguments,
- [Map<String,Object> namedArguments]) {
+ Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
+ [Map<String,Object> namedArguments]) {
if (namedArguments != null) {
throw new UnimplementedError(
'named argument support is not implemented');
@@ -501,9 +501,9 @@
String toString() => "ClassMirror on '$simpleName'";
- Future<InstanceMirror> newInstance(String constructorName,
- List positionalArguments,
- [Map<String,dynamic> namedArguments]) {
+ Future<InstanceMirror> newInstanceAsync(String constructorName,
+ List positionalArguments,
+ [Map<String,dynamic> namedArguments]) {
if (namedArguments != null) {
throw new UnimplementedError(
'named argument support is not implemented');
@@ -970,4 +970,10 @@
static InstanceMirror reflect(Object reflectee) {
return makeLocalInstanceMirror(reflectee);
}
+
+ static ClassMirror reflectClass(Type reflectee) {
+ throw new UnimplementedError('reflectClass is not implemented');
+ }
+
+
ahe 2013/04/10 05:52:22 Delete two extra lines.
}

Powered by Google App Engine
This is Rietveld 408576698