Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 13967003: EAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, se… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/isolate_mirror_local_test.dart ('k') | tests/lib/mirrors/mirrors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/mirrors/mirrors.dart
===================================================================
--- sdk/lib/mirrors/mirrors.dart (revision 21177)
+++ sdk/lib/mirrors/mirrors.dart (working copy)
@@ -174,32 +174,34 @@
abstract class ObjectMirror implements Mirror {
/**
* Invokes the named function and returns a mirror on the result.
- *
- * TODO(turnidge): Properly document.
+ * The arguments must be instances of [InstanceMirror], [num],
+ * [String] or [bool].
+ */
+ /* TODO(turnidge): Properly document.
* TODO(turnidge): Handle ambiguous names.
* TODO(turnidge): Handle optional & named arguments.
*/
- Future<InstanceMirror> invoke(String memberName,
- List<Object> positionalArguments,
- [Map<String,Object> namedArguments]);
+ Future<InstanceMirror> invokeAsync(String memberName,
+ List<Object> positionalArguments,
+ [Map<String,Object> namedArguments]);
/**
* Invokes a getter and returns a mirror on the result. The getter
* can be the implicit getter for a field or a user-defined getter
* method.
- *
- * TODO(turnidge): Handle ambiguous names.
*/
- Future<InstanceMirror> getField(String fieldName);
+ /* TODO(turnidge): Handle ambiguous names.*/
+ Future<InstanceMirror> getFieldAsync(String fieldName);
/**
* Invokes a setter and returns a mirror on the result. The setter
* may be either the implicit setter for a non-final field or a
* user-defined setter method.
- *
- * TODO(turnidge): Handle ambiguous names.
+ * The argument must be an instance of either [InstanceMirror], [num],
+ * [String] or [bool].
*/
- Future<InstanceMirror> setField(String fieldName, Object value);
+ /* TODO(turnidge): Handle ambiguous names.*/
+ Future<InstanceMirror> setFieldAsync(String fieldName, Object value);
}
/**
@@ -256,17 +258,12 @@
String get source;
/**
- * Executes the closure. The arguments given in the descriptor need to
- * be InstanceMirrors or simple values.
- *
- * A value is simple if one of the following holds:
- * - the value is null
- * - the value is of type [num]
- * - the value is of type [bool]
- * - the value is of type [String]
+ * Executes the closure.
+ * The arguments must be instances of [InstanceMirror], [num],
+ * [String] or [bool].
*/
- Future<InstanceMirror> apply(List<Object> positionalArguments,
- [Map<String,Object> namedArguments]);
+ Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
+ [Map<String,Object> namedArguments]);
/**
* Looks up the value of a name in the scope of the closure. The
@@ -436,12 +433,12 @@
/**
* Invokes the named constructor and returns a mirror on the result.
- *
- * TODO(turnidge): Properly document.
+ * The arguments must be instances of [InstanceMirror], [num],
*/
- Future<InstanceMirror> newInstance(String constructorName,
- List<Object> positionalArguments,
- [Map<String,Object> namedArguments]);
+ /* TODO(turnidge): Properly document.*/
+ Future<InstanceMirror> newInstanceAsync(String constructorName,
+ List<Object> positionalArguments,
+ [Map<String,Object> namedArguments]);
/**
* Does this mirror represent a class?
« no previous file with comments | « runtime/tests/vm/dart/isolate_mirror_local_test.dart ('k') | tests/lib/mirrors/mirrors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698