Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 13967003: EAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, se… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/mirrors/mirrors.dart
===================================================================
--- sdk/lib/mirrors/mirrors.dart (revision 21161)
+++ sdk/lib/mirrors/mirrors.dart (working copy)
@@ -174,12 +174,14 @@
abstract class ObjectMirror implements Mirror {
/**
* Invokes the named function and returns a mirror on the result.
+ * The arguments must be InstanceMirrors, numbers, strings
+ * or booleans.
*
* TODO(turnidge): Properly document.
* TODO(turnidge): Handle ambiguous names.
* TODO(turnidge): Handle optional & named arguments.
*/
- Future<InstanceMirror> invoke(String memberName,
+ Future<InstanceMirror> invokeAsync(String memberName,
List<Object> positionalArguments,
Ivan Posva 2013/04/10 00:30:10 Indentation.
[Map<String,Object> namedArguments]);
@@ -190,16 +192,18 @@
*
* TODO(turnidge): Handle ambiguous names.
*/
- Future<InstanceMirror> getField(String fieldName);
+ Future<InstanceMirror> getFieldAsync(String fieldName);
/**
* Invokes a setter and returns a mirror on the result. The setter
* may be either the implicit setter for a non-final field or a
* user-defined setter method.
+ * The argument must be either an InstanceMirrors, a number, a string
Ivan Posva 2013/04/10 00:30:10 InstanceMirror minus the s.
+ * or a boolean.
*
* TODO(turnidge): Handle ambiguous names.
*/
- Future<InstanceMirror> setField(String fieldName, Object value);
+ Future<InstanceMirror> setFieldAsync(String fieldName, Object value);
}
/**
@@ -265,7 +269,7 @@
* - the value is of type [bool]
* - the value is of type [String]
*/
- Future<InstanceMirror> apply(List<Object> positionalArguments,
+ Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
[Map<String,Object> namedArguments]);
Ivan Posva 2013/04/10 00:30:10 Indentation.
/**
@@ -436,10 +440,12 @@
/**
* Invokes the named constructor and returns a mirror on the result.
+ * The arguments must be InstanceMirrors, numbers, strings
+ * or booleans.
*
* TODO(turnidge): Properly document.
*/
- Future<InstanceMirror> newInstance(String constructorName,
+ Future<InstanceMirror> newInstanceAsync(String constructorName,
List<Object> positionalArguments,
Ivan Posva 2013/04/10 00:30:10 ditto
[Map<String,Object> namedArguments]);

Powered by Google App Engine
This is Rietveld 408576698