EAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, se…

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
   return (value == null || value is num || value is String || value is bool);
 }
@@ skipping 100 matching lines @@
   final bool isCurrent = true;
 
   var _rootLibrary;
   LibraryMirror get rootLibrary {
     if (_rootLibrary is _LazyLibraryMirror) {
       _rootLibrary = _rootLibrary.resolve(mirrors);
     }
     return _rootLibrary;
   }
 
-  String toString() => "IsolateMirror on '$debugName'";
+  String toString() => "IsolateMirror on '$debugName'"; 

[Ivan Posva, 2013/04/10 00:30:10]

Line ends in white space.

 }
 
 // A VMReference is used to hold a reference to a VM-internal object,
 // which can include things like libraries, classes, etc.
 class VMReference extends NativeFieldWrapperClass1 {
 }
 
 abstract class _LocalVMObjectMirrorImpl extends _LocalMirrorImpl {
   _LocalVMObjectMirrorImpl(this._reference) {}
 
   // For now, all VMObjects hold a VMReference.  We could consider
   // storing the Object reference itself here if the object is a Dart
   // language objects (except for objects of type VMReference, of
   // course).
   VMReference _reference;
 }
 
 abstract class _LocalObjectMirrorImpl extends _LocalVMObjectMirrorImpl
     implements ObjectMirror {
   _LocalObjectMirrorImpl(ref) : super(ref) {}
 
-  Future<InstanceMirror> invoke(String memberName,
+/* TODO: uncomment and correct
+InstanceMirror invoke(String memberName,
+                                List positionalArguments,
+                                [Map<String,dynamic> namedArguments]) {
+    if (namedArguments != null) {
+      throw new UnimplementedError(
+          'named argument support is not implemented');
+    }
+    return _invoke(this, memberName, positionalArguments)); // needs to be distinct for sync calls
+  }
+
+
+
+  InstanceMirror getField(String fieldName)
+  {
+        return _getField(this, fieldName); // needs to be distinct for sync calls

[Ivan Posva, 2013/04/10 00:30:10]

Please replace tab with spaces eventually.

+  }
+
+  InstanceMirror setField(String fieldName, Object arg)
+  {
+    return (_setField(this, fieldName, arg); // needs to be distinct for sync calls
+  }
+
+
+*/
+  
+Future<InstanceMirror> invokeAsync(String memberName,
                                 List positionalArguments,

[Ivan Posva, 2013/04/10 00:30:10]

Indentation.

                                 [Map<String,dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _validateArgument(i, arg);
     }
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(
           _invoke(this, memberName, positionalArguments));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
   }
 
-  Future<InstanceMirror> getField(String fieldName)
+  Future<InstanceMirror> getFieldAsync(String fieldName)
   {
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(_getField(this, fieldName));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
   }
 
-  Future<InstanceMirror> setField(String fieldName, Object arg)
+  Future<InstanceMirror> setFieldAsync(String fieldName, Object arg)
   {
     _validateArgument(0, arg);
 
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(_setField(this, fieldName, arg));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
@@ skipping 111 matching lines @@
                           reflectee,
                           this.function) : super(ref, type, reflectee) {}
 
   final MethodMirror function;
 
   String get source {
     throw new UnimplementedError(
         'ClosureMirror.source is not implemented');
   }
 
-  Future<InstanceMirror> apply(List<Object> positionalArguments,
+  Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
                                [Map<String,Object> namedArguments]) {

[Ivan Posva, 2013/04/10 00:30:10]

Indentation.

     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
@@ skipping 174 matching lines @@
         'ClassMirror.isOriginalDeclaration is not implemented');
   }
 
   ClassMirror get genericDeclaration {
     throw new UnimplementedError(
         'ClassMirror.originalDeclaration is not implemented');
   }
 
   String toString() => "ClassMirror on '$simpleName'";
 
-  Future<InstanceMirror> newInstance(String constructorName,
+  Future<InstanceMirror> newInstanceAsync(String constructorName,
                                      List positionalArguments,

[Ivan Posva, 2013/04/10 00:30:10]

Indentation.

                                      [Map<String,dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
@@ skipping 447 matching lines @@
   }
 
   // Creates a new local InstanceMirror
   static InstanceMirror makeLocalInstanceMirror(Object reflectee)
       native 'Mirrors_makeLocalInstanceMirror';
 
   // Creates a new local mirror for some Object.
   static InstanceMirror reflect(Object reflectee) {
     return makeLocalInstanceMirror(reflectee);
   }
+
+  static ClassMirror reflectClass(Type reflectee) {
+    throw new UnimplementedError('reflectClass is not implemented');
+  }
+
+
 }