Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1396693004: Fix for top level variable documention ranges. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-09 15:49:02 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-09 17:39:06 UTC) #2
scheglov
5 years, 2 months ago (2015-10-09 17:39:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14ab3cae4d36d2ef41fd023a0041a262d2b0d852 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698