Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: components/policy/BUILD.gn

Issue 1396663005: Revert of Make chrome/common pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/third_party/mozilla_security_manager/BUILD.gn ('k') | extensions/common/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//components/policy/resources/policy_templates.gni") 7 import("//components/policy/resources/policy_templates.gni")
8 import("//third_party/protobuf/proto_library.gni") 8 import("//third_party/protobuf/proto_library.gni")
9 import("//tools/grit/grit_rule.gni") 9 import("//tools/grit/grit_rule.gni")
10 10
11 # About the policy component: 11 # About the policy component:
12 # 12 #
13 # There should really be two components. One called "policy" that includes all 13 # There should really be two components. One called "policy" that includes all
14 # generated code, and one "policy/proto" like we have now. The proto needs to 14 # generated code, and one "policy/proto" like we have now. The proto needs to
15 # be separate for cases like SesssionManagerClient which uses the protos to 15 # be separate for cases like SesssionManagerClient which uses the protos to
16 # communicate with the Chrome OS system layer, but doesn't need the rest of the 16 # communicate with the Chrome OS system layer, but doesn't need the rest of the
17 # policy stuff). 17 # policy stuff).
18 # 18 #
19 # The reason the rest of the targets exist are artifacts of the way the GYP 19 # The reason the rest of the targets exist are artifacts of the way the GYP
20 # build works. The current "policy" target which is really just some generated 20 # build works. The current "policy" target which is really just some generated
21 # code (which should be folded into the new "policy" component described above) 21 # code (which should be folded into the new "policy" component described above)
22 # exists so code outside which depends on the generated headers can depend on 22 # exists so code outside which depends on the generated headers can depend on
23 # the hard policy target without having to make all policy targets hard 23 # the hard policy target without having to make all policy targets hard
24 # dependencies (GN will do the right thing without this extra target). 24 # dependencies (GN will do the right thing without this extra target).
25 if (is_component_build) { 25 if (is_component_build) {
26 component("policy_component") { 26 component("policy_component") {
27 public_deps = [ 27 deps = [
28 "//components/policy/core/browser", 28 "//components/policy/core/browser",
29 "//components/policy/core/common", 29 "//components/policy/core/common",
30 ] 30 ]
31 } 31 }
32 group("policy_component_browser") { 32 group("policy_component_browser") {
33 public_deps = [ 33 deps = [
34 ":policy_component", 34 ":policy_component",
35 ] 35 ]
36 } 36 }
37 group("policy_component_common") { 37 group("policy_component_common") {
38 public_deps = [ 38 deps = [
39 ":policy_component", 39 ":policy_component",
40 ] 40 ]
41 } 41 }
42 } else { # Compile to separate libraries. 42 } else { # Compile to separate libraries.
43 group("policy_component") { 43 group("policy_component") {
44 public_deps = [ 44 deps = [
45 ":policy_component_browser", 45 ":policy_component_browser",
46 ":policy_component_common", 46 ":policy_component_common",
47 ] 47 ]
48 } 48 }
49 component("policy_component_browser") { 49 component("policy_component_browser") {
50 public_deps = [ 50 deps = [
51 "//components/policy/core/browser", 51 "//components/policy/core/browser",
52 ] 52 ]
53 } 53 }
54 component("policy_component_common") { 54 component("policy_component_common") {
55 public_deps = [ 55 deps = [
56 "//components/policy/core/common", 56 "//components/policy/core/common",
57 ] 57 ]
58 } 58 }
59 } 59 }
60 60
61 if (enable_configuration_policy) { 61 if (enable_configuration_policy) {
62 # TODO(brettw) this component should use target_gen_dir instead but the GYP 62 # TODO(brettw) this component should use target_gen_dir instead but the GYP
63 # build puts everything into the following directory. We do the same for now. 63 # build puts everything into the following directory. We do the same for now.
64 policy_gen_dir = "$root_gen_dir/policy" 64 policy_gen_dir = "$root_gen_dir/policy"
65 65
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 336
337 group("app_restrictions_resources") { 337 group("app_restrictions_resources") {
338 deps = [ 338 deps = [
339 ":$build_config_target_name", 339 ":$build_config_target_name",
340 ":$zip_target_name", 340 ":$zip_target_name",
341 ] 341 ]
342 } 342 }
343 } 343 }
344 } 344 }
345 #TODO(GYP) chrome_manifest_bundle 345 #TODO(GYP) chrome_manifest_bundle
OLDNEW
« no previous file with comments | « chrome/third_party/mozilla_security_manager/BUILD.gn ('k') | extensions/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698