Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 1396663002: Revert "Use interceptors for is-checks (version 2)." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index 4693bad24e8ef90ed0bb1a6ec76b2455c426fbc1..ddaf34ddef5ba9362866db110393ff39be81d8fe 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -404,8 +404,6 @@ class Conditional extends Expression {
/// An && or || expression. The operator is internally represented as a boolean
/// [isAnd] to simplify rewriting of logical operators.
-/// Note the the result of && and || is one of the arguments, which might not be
-/// boolean. 'ShortCircuitOperator' might have been a better name.
class LogicalOperator extends Expression {
Expression left;
bool isAnd;
@@ -744,22 +742,6 @@ class SetField extends Expression {
accept1(ExpressionVisitor1 visitor, arg) => visitor.visitSetField(this, arg);
}
-
-/// Read the type test property from [object]. The value is truthy/fasly rather
-/// than bool. [object] must not be `null`.
-class GetTypeTestProperty extends Expression {
- Expression object;
- DartType dartType;
-
- GetTypeTestProperty(this.object, this.dartType);
-
- accept(ExpressionVisitor visitor) =>
- visitor.visitGetTypeTestProperty(this);
- accept1(ExpressionVisitor1 visitor, arg) =>
- visitor.visitGetTypeTestProperty(this, arg);
-}
-
-
/// Read the value of a field, possibly provoking its initializer to evaluate,
/// or tear off a static method.
class GetStatic extends Expression {
@@ -993,7 +975,6 @@ abstract class ExpressionVisitor<E> {
E visitSetField(SetField node);
E visitGetStatic(GetStatic node);
E visitSetStatic(SetStatic node);
- E visitGetTypeTestProperty(GetTypeTestProperty node);
E visitCreateBox(CreateBox node);
E visitCreateInstance(CreateInstance node);
E visitReifyRuntimeType(ReifyRuntimeType node);
@@ -1031,7 +1012,6 @@ abstract class ExpressionVisitor1<E, A> {
E visitSetField(SetField node, A arg);
E visitGetStatic(GetStatic node, A arg);
E visitSetStatic(SetStatic node, A arg);
- E visitGetTypeTestProperty(GetTypeTestProperty node, A arg);
E visitCreateBox(CreateBox node, A arg);
E visitCreateInstance(CreateInstance node, A arg);
E visitReifyRuntimeType(ReifyRuntimeType node, A arg);
@@ -1226,10 +1206,6 @@ abstract class RecursiveVisitor implements StatementVisitor, ExpressionVisitor {
visitExpression(node.value);
}
- visitGetTypeTestProperty(GetTypeTestProperty node) {
- visitExpression(node.object);
- }
-
visitCreateBox(CreateBox node) {
}
@@ -1475,11 +1451,6 @@ class RecursiveTransformer extends Transformer {
return node;
}
- visitGetTypeTestProperty(GetTypeTestProperty node) {
- node.object = visitExpression(node.object);
- return node;
- }
-
visitCreateBox(CreateBox node) => node;
visitCreateInstance(CreateInstance node) {
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698