Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1396663002: Revert "Use interceptors for is-checks (version 2)." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
index a1f28eeae65b808e427aa7de59ffbfb67c1a37c3..3f68eed7bee66f6c2bdc18a92988536dd6563611 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
@@ -229,18 +229,6 @@ class UnsugarVisitor extends RecursiveVisitor implements Pass {
// worry about unlinking.
}
- // TODO(24523): Insert interceptor on demand when we discover we want to use
- // one rather than on every check.
- processTypeTest(TypeTest node) {
- assert(node.interceptor == null);
- Primitive receiver = node.value.definition;
- Primitive interceptor = new Interceptor(receiver, node.sourceInformation)
- ..interceptedClasses.addAll(_glue.interceptedClasses);
- insertLetPrim(interceptor, node.parent);
- node.interceptor = new Reference<Primitive>(interceptor);
- node.interceptor.parent = node;
- }
-
processInvokeMethod(InvokeMethod node) {
Selector selector = node.selector;
if (!_glue.isInterceptedSelector(selector)) return;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698