Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/glue.dart

Issue 1396663002: Revert "Use interceptors for is-checks (version 2)." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/glue.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/glue.dart b/pkg/compiler/lib/src/js_backend/codegen/glue.dart
index 8b99d380dc3568bf3255268875e66277022daaf0..3a229e385e697d437149bb76dcda6627f246316d 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/glue.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/glue.dart
@@ -7,8 +7,6 @@ library code_generator_dependencies;
import '../js_backend.dart';
import '../../common/registry.dart' show
Registry;
-import '../../common/codegen.dart' show
- CodegenRegistry;
import '../../compiler.dart' show
Compiler;
import '../../constants/values.dart';
@@ -25,7 +23,6 @@ import '../../enqueue.dart' show
import '../../elements/elements.dart';
import '../../js_emitter/js_emitter.dart';
import '../../js/js.dart' as js;
-import '../../native/native.dart' show NativeBehavior;
import '../../universe/selector.dart' show
Selector;
import '../../world.dart' show
@@ -135,10 +132,6 @@ class Glue {
return _backend.getInterceptedClassesOn(selector.name);
}
- Set<ClassElement> get interceptedClasses {
- return _backend.interceptedClasses;
- }
-
void registerSpecializedGetInterceptor(Set<ClassElement> classes) {
_backend.registerSpecializedGetInterceptor(classes);
}
@@ -241,15 +234,12 @@ class Glue {
}
js.Expression generateTypeRepresentation(DartType dartType,
- List<js.Expression> arguments,
- CodegenRegistry registry) {
+ List<js.Expression> arguments) {
int variableIndex = 0;
js.Expression representation = _backend.rti.getTypeRepresentation(
dartType,
(_) => arguments[variableIndex++]);
assert(variableIndex == arguments.length);
- // Representation contains JavaScript Arrays.
- registry.registerInstantiatedClass(_backend.jsArrayClass);
return representation;
}
@@ -274,10 +264,7 @@ class Glue {
return _compiler.world.hasAnyStrictSubtype(element);
}
- ClassElement get jsFixedArrayClass => _backend.jsFixedArrayClass;
ClassElement get jsExtendableArrayClass => _backend.jsExtendableArrayClass;
- ClassElement get jsUnmodifiableArrayClass =>
- _backend.jsUnmodifiableArrayClass;
ClassElement get jsMutableArrayClass => _backend.jsMutableArrayClass;
bool isStringClass(ClassElement classElement) =>
@@ -287,10 +274,4 @@ class Glue {
bool isBoolClass(ClassElement classElement) =>
classElement == _backend.jsBoolClass ||
classElement == _compiler.boolClass;
-
- // TODO(sra): Should this be part of CodegenRegistry?
- void registerNativeBehavior(NativeBehavior nativeBehavior, node) {
- if (nativeBehavior == null) return;
- _enqueuer.nativeEnqueuer.registerNativeBehavior(nativeBehavior, node);
- }
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/unsugar.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698