Issue 1396663002: Revert "Use interceptors for is-checks (version 2)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396663002: Revert "Use interceptors for is-checks (version 2)." (Closed)

Created:
5 years, 2 months ago by sra1

Modified:
5 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Use interceptors for is-checks (version 2)." Need to fix some analyzer warnings. TBR=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/89b6d8e74960dec2fd87011538227ab515d0fc8d

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -308 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/builtin_operator.dart	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	4 chunks	+8 lines, -38 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_mask_system.dart	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	3 chunks	+13 lines, -75 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	4 chunks	+13 lines, -23 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	6 chunks	+1 line, -20 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View	6 chunks	+0 lines, -29 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_rti.dart	View	1 chunk	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sra1

5 years, 2 months ago (2015-10-07 23:29:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89b6d8e74960dec2fd87011538227ab515d0fc8d (presubmit successful).

Expand Messages | Collapse Messages