Issue 139663005: A64: fix after r18982.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139663005: A64: fix after r18982. (Closed)

Created:
6 years, 10 months ago by ulan

Modified:
6 years, 10 months ago

Reviewers:
m.m.capewell, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: fix after r18982. Register x19 is used by a caller of the stub. BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18988

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/a64/code-stubs-a64.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://codereview.chromium.org/139663005/diff/1/src/a64/code-stubs-a64.cc File src/a64/code-stubs-a64.cc (right): https://codereview.chromium.org/139663005/diff/1/src/a64/code-stubs-a64.cc#newcode1330 src/a64/code-stubs-a64.cc:1330: Register heap_result = x21; hum, it's a callee preserved ...

6 years, 10 months ago (2014-01-31 13:42:29 UTC) #2

jochen (gone - plz use gerrit)

lgtm after local discussion - it's just calls between stubs where we don't follow th ...

6 years, 10 months ago (2014-01-31 13:43:23 UTC) #3

ulan

6 years, 10 months ago (2014-01-31 13:44:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18988 (tree was closed).

Expand Messages | Collapse Messages