Issue 1396613007: Stop benching PNG buildTileIndex by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396613007: Stop benching PNG buildTileIndex by default (Closed)

Created:
5 years, 2 months ago by scroggo

Modified:
5 years, 2 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Stop benching PNG buildTileIndex by default It leaks memory and kills the bots. Supply an option to run it for local comparison. BUG=skia:4360 BUG=skia:3418 Committed: https://skia.googlesource.com/skia/+/2da1a854b0836001533aa29ade89d87f420cbbc3

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	bench/nanobench.cpp	View		3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396613007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396613007/1

5 years, 2 months ago (2015-10-13 20:26:10 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-13 20:33:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2da1a854b0836001533aa29ade89d87f420cbbc3

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages