Use permissions 0666 on POSIX platforms except Android

Use permissions 0666 on POSIX platforms

Revert the hack introduced by http://crrev.com/290143005

BUG=409416
Committed: https://crrev.com/8a24d2b903636c83780281400aeba6164fdb358a
Cr-Commit-Position: refs/heads/master@{#353963}

[hashimoto, 2015-10-13 08:33:42]

hashimoto@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-10-13 08:46:40]

Uhh, probably ok, but let's see what aurimas says in regard to my question:

Is bug 362887 an ICS-only issue? If yes, shouldn't we just go back to
permissions 0666, since we deprecated Chrome for ICS earlier this year?

https://codereview.chromium.org/1396613004/diff/1/base/files/file_util_posix.cc
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1396613004/diff/1/base/files/file_util_posix....
base/files/file_util_posix.cc:677: #if !defined(OS_ANDROID)
nit: how about being positive with if-else defines (and statements) ? (See ToTT
387)

[aurimas (slooooooooow), 2015-10-13 17:09:34]

aurimas@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-10-13 17:09:34]

We can switch to 0666 everywhere as we did drop ICS support.

[Lei Zhang, 2015-10-13 17:42:23]

On 2015/10/13 17:09:34, aurimas wrote:
> We can switch to 0666 everywhere as we did drop ICS support.

SGTM!

[hashimoto, 2015-10-14 03:18:14]

Uploaded a new patch set which just replaces 0640 with 0666
PTAL

https://codereview.chromium.org/1396613004/diff/1/base/files/file_util_posix.cc
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1396613004/diff/1/base/files/file_util_posix....
base/files/file_util_posix.cc:677: #if !defined(OS_ANDROID)
On 2015/10/13 08:46:40, Lei Zhang wrote:
> nit: how about being positive with if-else defines (and statements) ? (See
ToTT
> 387)

Acknowledged.

[Lei Zhang, 2015-10-14 04:50:41]

lgtm

[hashimoto, 2015-10-14 04:52:39]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2015-10-14 04:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396613004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396613004/20001

[commit-bot: I haz the power, 2015-10-14 05:19:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-14 05:20:05]

Patchset 2 (id:??) landed as
https://crrev.com/8a24d2b903636c83780281400aeba6164fdb358a
Cr-Commit-Position: refs/heads/master@{#353963}