Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396603002: Properly split dart:_vmservice across sdk and runtime (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly split dart:_vmservice across sdk and runtime - This is needed to satisfy the GN build system (mojo, flutter). - It also makes dart:_vmservice even more regular with othe rlibraries. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4831a1a315c6f9722028ed53bd947bc56591457e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -690 lines) Patch
D runtime/lib/vmservice/client.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D runtime/lib/vmservice/constants.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/lib/vmservice/message.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D runtime/lib/vmservice/message_router.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D runtime/lib/vmservice/running_isolate.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/lib/vmservice/running_isolates.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/lib/vmservice/vmservice.dart View 1 chunk +0 lines, -331 lines 0 comments Download
A runtime/lib/vmservice_patch.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/lib/vmservice_sources.gypi View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/BUILD.gn View 5 chunks +1 line, -29 lines 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +46 lines, -2 lines 0 comments Download
A + sdk/lib/vmservice/client.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/vmservice/constants.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/vmservice/message.dart View 1 chunk +2 lines, -5 lines 0 comments Download
A + sdk/lib/vmservice/message_router.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/vmservice/running_isolate.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/vmservice/running_isolates.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/vmservice/vmservice.dart View 2 chunks +7 lines, -6 lines 0 comments Download
A + sdk/lib/vmservice/vmservice_sources.gypi View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 2 months ago (2015-10-07 20:12:26 UTC) #2
rmacnak
lgtm
5 years, 2 months ago (2015-10-07 20:14:51 UTC) #3
Cutch
5 years, 2 months ago (2015-10-07 20:20:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4831a1a315c6f9722028ed53bd947bc56591457e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698