Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 13966012: Revert 195553 "Allow showing pending URL for new tab navigations..." (Closed)

Created:
7 years, 8 months ago by Charlie Reis
Modified:
7 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195553 "Allow showing pending URL for new tab navigations..." Caused spike in renderer crashes. > Allow showing pending URL for new tab navigations, but only if safe. > > We revert to showing the opener's URL if it modifies the content of the > initial blank page before the pending URL commits, to prevent URL spoofs. > > Implications: > - All renderer-initiated navigations now have pending NavigationEntries. > - GetURL and GetTitle use the visible entry, not active entry. > - The renderer notifies the browser if DOM mutations occur before first load. > > [Second attempt, after http://crrev.com/191277 was reverted.] > > BUG=9682 > TEST=Open a slow link in a new tab. Destination URL should be visible and reloadable. > > Review URL: https://chromiumcodereview.appspot.com/13846007 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -409 lines) Patch
M trunk/src/chrome/browser/external_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_mode_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/constrained_window_views_browsertest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 3 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M trunk/src/content/browser/web_contents/navigation_controller_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/web_contents/navigation_controller_impl.cc View 7 chunks +20 lines, -59 lines 0 comments Download
M trunk/src/content/browser/web_contents/navigation_controller_impl_unittest.cc View 8 chunks +20 lines, -114 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.cc View 5 chunks +2 lines, -31 lines 0 comments Download
M trunk/src/content/common/view_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D trunk/src/content/test/data/click-nocontent-link.html View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Reis
7 years, 8 months ago (2013-04-24 01:26:34 UTC) #1
Charlie Reis
7 years, 8 months ago (2013-04-24 01:27:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195970.

Powered by Google App Engine
This is Rietveld 408576698