Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1396523005: VectorICs: turn on vectors for STORE and KEYED_STORE ics. (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: turn on vectors for STORE and KEYED_STORE ics. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab Cr-Commit-Position: refs/heads/master@{#31252} Committed: https://crrev.com/31487015de401892b4d12b5faef0c47c201308da Cr-Commit-Position: refs/heads/master@{#31305} Committed: https://crrev.com/4d98941e1896305b05e4e04efb33ade8e5b4e379 Cr-Commit-Position: refs/heads/master@{#31419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (6 generated)
mvstanton
Hi Jakob, Here is the first run at turning on the flag. Thanks, --Michael
5 years, 2 months ago (2015-10-12 15:50:31 UTC) #1
Jakob Kummerow
Buckle your seatbelts. LGTM.
5 years, 2 months ago (2015-10-13 11:06:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1
5 years, 2 months ago (2015-10-14 09:03:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 09:27:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab Cr-Commit-Position: refs/heads/master@{#31252}
5 years, 2 months ago (2015-10-14 09:28:00 UTC) #6
mvstanton
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1398123003/ by mvstanton@chromium.org. ...
5 years, 2 months ago (2015-10-14 10:52:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1
5 years, 2 months ago (2015-10-15 12:06:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 13:35:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31487015de401892b4d12b5faef0c47c201308da Cr-Commit-Position: refs/heads/master@{#31305}
5 years, 2 months ago (2015-10-15 13:35:24 UTC) #11
mvstanton
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1406163002/ by mvstanton@chromium.org. ...
5 years, 2 months ago (2015-10-16 08:25:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1
5 years, 2 months ago (2015-10-20 08:44:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9783)
5 years, 2 months ago (2015-10-20 09:28:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1
5 years, 2 months ago (2015-10-20 15:08:44 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 15:27:48 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 15:28:10 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d98941e1896305b05e4e04efb33ade8e5b4e379
Cr-Commit-Position: refs/heads/master@{#31419}

Powered by Google App Engine
This is Rietveld 408576698