| 
    
      
  | 
  
 Chromium Code Reviews| 
         Created: 
          5 years, 2 months ago by mvstanton Modified: 
          5 years, 2 months ago Reviewers: 
          
          Jakob Kummerow CC: 
          
          
          v8-reviews_googlegroups.com Base URL: 
          
          
          https://chromium.googlesource.com/v8/v8.git@master Target Ref: 
          
          
          refs/pending/heads/master Project: 
          
          v8 Visibility: 
          
          
          
        Public.  | 
      
        
  DescriptionVectorICs: turn on vectors for STORE and KEYED_STORE ics.
R=jkummerow@chromium.org
BUG=
Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab
Cr-Commit-Position: refs/heads/master@{#31252}
Committed: https://crrev.com/31487015de401892b4d12b5faef0c47c201308da
Cr-Commit-Position: refs/heads/master@{#31305}
Committed: https://crrev.com/4d98941e1896305b05e4e04efb33ade8e5b4e379
Cr-Commit-Position: refs/heads/master@{#31419}
   
  Patch Set 1 #
 Messages
    Total messages: 21 (6 generated)
     
  
  
 Hi Jakob, Here is the first run at turning on the flag. Thanks, --Michael 
 Buckle your seatbelts. LGTM. 
 The CQ bit was checked by mvstanton@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #1 (id:1) 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Patchset 1 (id:??) landed as https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab Cr-Commit-Position: refs/heads/master@{#31252} 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1398123003/ by mvstanton@chromium.org. The reason for reverting is: Windows crash failure, must be investigated.. 
 The CQ bit was checked by mvstanton@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #1 (id:1) 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Patchset 1 (id:??) landed as https://crrev.com/31487015de401892b4d12b5faef0c47c201308da Cr-Commit-Position: refs/heads/master@{#31305} 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1406163002/ by mvstanton@chromium.org. The reason for reverting is: We harvested enough information now about the windows crash. We'll investigate that and reland when fixed.. 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Description was changed from ========== VectorICs: turn on vectors for STORE and KEYED_STORE ics. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab Cr-Commit-Position: refs/heads/master@{#31252} Committed: https://crrev.com/31487015de401892b4d12b5faef0c47c201308da Cr-Commit-Position: refs/heads/master@{#31305} ========== to ========== VectorICs: turn on vectors for STORE and KEYED_STORE ics. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab Cr-Commit-Position: refs/heads/master@{#31252} Committed: https://crrev.com/31487015de401892b4d12b5faef0c47c201308da Cr-Commit-Position: refs/heads/master@{#31305} ========== 
 The CQ bit was checked by mvstanton@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9783) 
 The CQ bit was checked by mvstanton@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396523005/1 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #1 (id:1) 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Patchset 1 (id:??) landed as https://crrev.com/4d98941e1896305b05e4e04efb33ade8e5b4e379 Cr-Commit-Position: refs/heads/master@{#31419}  | 
    ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
