Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: PRESUBMIT.py

Issue 1396523002: Automatically add TSAN bots to the CQ for changes affecting SkAtomics.h (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fmt Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Top-level presubmit script for Skia. 6 """Top-level presubmit script for Skia.
7 7
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl. 9 for more details about the presubmit API built into gcl.
10 """ 10 """
(...skipping 26 matching lines...) Expand all
37 37
38 DOCS_PREVIEW_URL = 'https://skia.org/?cl=' 38 DOCS_PREVIEW_URL = 'https://skia.org/?cl='
39 39
40 # Path to CQ bots feature is described in skbug.com/4364 40 # Path to CQ bots feature is described in skbug.com/4364
41 PATH_PREFIX_TO_EXTRA_TRYBOTS = { 41 PATH_PREFIX_TO_EXTRA_TRYBOTS = {
42 # pylint: disable=line-too-long 42 # pylint: disable=line-too-long
43 'cmake/': 'client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Tryb ot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot', 43 'cmake/': 'client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Tryb ot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot',
44 # pylint: disable=line-too-long 44 # pylint: disable=line-too-long
45 'src/opts/': 'client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_N O_SIMD-Trybot', 45 'src/opts/': 'client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_N O_SIMD-Trybot',
46 46
47 'include/private/SkAtomics.h': ('client.skia:'
48 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,'
49 'Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot'
50 ),
51
47 # Below are examples to show what is possible with this feature. 52 # Below are examples to show what is possible with this feature.
48 # 'src/svg/': 'master1:abc;master2:def', 53 # 'src/svg/': 'master1:abc;master2:def',
49 # 'src/svg/parser/': 'master3:ghi,jkl;master4:mno', 54 # 'src/svg/parser/': 'master3:ghi,jkl;master4:mno',
50 # 'src/image/SkImage_Base.h': 'master5:pqr,stu;master1:abc1;master2:def', 55 # 'src/image/SkImage_Base.h': 'master5:pqr,stu;master1:abc1;master2:def',
51 } 56 }
52 57
53 58
54 def _CheckChangeHasEol(input_api, output_api, source_file_filter=None): 59 def _CheckChangeHasEol(input_api, output_api, source_file_filter=None):
55 """Checks that files end with atleast one \n (LF).""" 60 """Checks that files end with atleast one \n (LF)."""
56 eof_files = [] 61 eof_files = []
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 state and an error if it is in 'Closed' state. 504 state and an error if it is in 'Closed' state.
500 """ 505 """
501 results = [] 506 results = []
502 results.extend(_CommonChecks(input_api, output_api)) 507 results.extend(_CommonChecks(input_api, output_api))
503 results.extend( 508 results.extend(
504 _CheckTreeStatus(input_api, output_api, json_url=( 509 _CheckTreeStatus(input_api, output_api, json_url=(
505 SKIA_TREE_STATUS_URL + '/banner-status?format=json'))) 510 SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
506 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api)) 511 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
507 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api)) 512 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
508 return results 513 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698