third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html - Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html

Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Layout test expectation changed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html ('K') | « third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt ('k') | third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 td { font: 15px/1 Ahem }
	mstensho (USE GERRIT) 2016/01/12 10:06:41 Better come up with a test that passes on all plat Better come up with a test that passes on all platforms, rather than this platform specific test. Maybe using 20px/1 here would solve the problem? a.suchit2 2016/01/12 14:37:02 changed and trying. Show quoted text On 2016/01/12 10:06:41, mstensho wrote: > Better come up with a test that passes on all platforms, rather than this > platform specific test. Maybe using 20px/1 here would solve the problem? changed and trying.
	4 </style>

	5 <script src="../../resources/check-layout.js"></script>

	6 <body>

	7 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=445253">445253</a>. Setting rowspan=2 on the table cell causes the whole table to resize again and again.</h3>

	8 <table border="1" data-expected-height="45">

	9 <tr>

	10 <td/>

	11 <td rowspan="2" id="ta"><textarea style='height:100%;'>Text area tex t</textarea></td>
	mstensho (USE GERRIT) 2016/01/12 10:06:41 Also, textarea sets font on its own, so your Ahem Also, textarea sets font on its own, so your Ahem isn't inherited. Maybe add "textarea" to the selector above? a.suchit2 2016/01/12 14:37:02 Done. Show quoted text On 2016/01/12 10:06:41, mstensho wrote: > Also, textarea sets font on its own, so your Ahem isn't inherited. Maybe add > "textarea" to the selector above? Done.
	12 </tr>

	13 <tr>

	14 <td/>

	15 <td></td>

	16 </tr>

	17 </table>

	18 </body>

	19

	20 <script>

	21 document.body.offsetTop;

	22 document.getElementById("ta").rowSpan="2";

	23 checkLayout('table');

	24 </script>

OLD	NEW