Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1396493002: [Interpreter] Add ignition-script-filter flag to filter scripts. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add ignition-script-filter flag to filter scripts. Add a flag to explicitly filter scripts in ignition and use it for the test262 variant. The previous approach of overloading ignition-filter meant that only top-level code was getting compiled through ignition. BUG=v8:4280 LOG=N Committed: https://crrev.com/6e64a057e324de0279159c7495b3eeca33140649 Cr-Commit-Position: refs/heads/master@{#31164}

Patch Set 1 #

Patch Set 2 : Fix cctests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M src/compiler.cc View 1 4 chunks +22 lines, -14 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262/testcfg.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396493002/1
5 years, 2 months ago (2015-10-07 15:25:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10454)
5 years, 2 months ago (2015-10-07 15:37:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396493002/40001
5 years, 2 months ago (2015-10-07 17:14:39 UTC) #7
rmcilroy
Michi: Here is the fix to make the filters work correctly for the test262 tests. ...
5 years, 2 months ago (2015-10-07 17:39:03 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 17:41:50 UTC) #11
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-10-07 18:22:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396493002/40001
5 years, 2 months ago (2015-10-07 19:05:06 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-07 19:08:39 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 19:08:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e64a057e324de0279159c7495b3eeca33140649
Cr-Commit-Position: refs/heads/master@{#31164}

Powered by Google App Engine
This is Rietveld 408576698