Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1396443004: Reduce method visibility in Tab.java (Closed)

Created:
5 years, 2 months ago by aurimas (slooooooooow)
Modified:
5 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce method visibility in Tab.java BUG=532216 Committed: https://crrev.com/d6733c8d11cbe190415a20f7221b142f7fe60b87 Cr-Commit-Position: refs/heads/master@{#353431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -50 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 23 chunks +26 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 2 months ago (2015-10-09 22:46:29 UTC) #2
Ted C
lgtm
5 years, 2 months ago (2015-10-09 22:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396443004/1
5 years, 2 months ago (2015-10-09 23:01:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-10 00:21:28 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 00:22:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6733c8d11cbe190415a20f7221b142f7fe60b87
Cr-Commit-Position: refs/heads/master@{#353431}

Powered by Google App Engine
This is Rietveld 408576698