Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

Issue 1396403004: Remove dependency on Finch experiment PasswordLinkInSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Java comment addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
index 343cda1fb0d8127346ddcfb146c21cf51e4e809e..cb609b119262a1752f08ae850784a78d44b0bd99 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
@@ -314,9 +314,7 @@ public class SavePasswordsPreferences extends PreferenceFragment
}
private void displayManageAccountLink() {
- boolean shouldDisplayLink = PasswordUIView.shouldDisplayManageAccountLink();
- if (shouldDisplayLink
- && getPreferenceScreen().findPreference(PREF_MANAGE_ACCOUNT_LINK) == null) {
+ if (getPreferenceScreen().findPreference(PREF_MANAGE_ACCOUNT_LINK) == null) {
if (mLinkPref == null) {
ForegroundColorSpan colorSpan = new ForegroundColorSpan(
ApiCompatibilityUtils.getColor(getResources(), R.color.pref_accent_color));
@@ -331,8 +329,5 @@ public class SavePasswordsPreferences extends PreferenceFragment
}
getPreferenceScreen().addPreference(mLinkPref);
}
- // Draw a divider only if the preference after mSavePasswordsSwitch is not selectable,
- // in which case the ListView itself doesn't draw a divider.
- mSavePasswordsSwitch.setDrawDivider(!shouldDisplayLink && mAutoSignInSwitch == null);
}
}

Powered by Google App Engine
This is Rietveld 408576698