Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: components/password_manager/core/common/experiments.cc

Issue 1396403004: Remove dependency on Finch experiment PasswordLinkInSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Java comment addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/common/experiments.h" 5 #include "components/password_manager/core/common/experiments.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/field_trial.h"
9 #include "components/password_manager/core/common/password_manager_switches.h" 8 #include "components/password_manager/core/common/password_manager_switches.h"
10 9
11 namespace password_manager { 10 namespace password_manager {
12 11
13 bool ManageAccountLinkExperimentEnabled() {
14 std::string group_name =
15 base::FieldTrialList::FindFullName("PasswordLinkInSettings");
16
17 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
18 if (command_line->HasSwitch(switches::kDisablePasswordLink))
19 return false;
20
21 if (command_line->HasSwitch(switches::kEnablePasswordLink))
22 return true;
23
24 // To match Finch enabling the experiment by default, this method returns true
25 // unless explicitly told the experiment is disabled. This ensures trybot
26 // coverage of the enabled case.
27 return group_name != "Disabled";
28 }
29
30 bool ForceSavingExperimentEnabled() { 12 bool ForceSavingExperimentEnabled() {
31 return base::CommandLine::ForCurrentProcess()->HasSwitch( 13 return base::CommandLine::ForCurrentProcess()->HasSwitch(
32 password_manager::switches::kEnablePasswordForceSaving); 14 password_manager::switches::kEnablePasswordForceSaving);
33 } 15 }
34 16
35 } // namespace password_manager 17 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698