Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1396333004: Bailout to runtime when BuildUncheckedStringAdd results in a large object. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bailout to runtime when BuildUncheckedStringAdd results in a large object. BUG= Committed: https://crrev.com/a0159c116865b15b361cdc0d851c762e41441272 Cr-Commit-Position: refs/heads/master@{#31258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -46 lines) Patch
M src/hydrogen.cc View 1 chunk +56 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-14 12:05:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396333004/1
5 years, 2 months ago (2015-10-14 12:14:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 12:58:53 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 12:59:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0159c116865b15b361cdc0d851c762e41441272
Cr-Commit-Position: refs/heads/master@{#31258}

Powered by Google App Engine
This is Rietveld 408576698