Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1396323011: Native context: use import/export for Object observe related functions. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: use import/export for Object observe related functions. R=adamk@chromium.org Committed: https://crrev.com/b6c945642c77fdebbe053e6f7fb29c07cda5806c Cr-Commit-Position: refs/heads/master@{#31279}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M src/js/array.js View 1 9 chunks +24 lines, -18 lines 0 comments Download
M src/js/harmony-object-observe.js View 1 chunk +5 lines, -2 lines 0 comments Download
M src/js/object-observe.js View 4 chunks +13 lines, -15 lines 0 comments Download
M src/js/prologue.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years, 2 months ago (2015-10-15 07:09:38 UTC) #1
Yang
On 2015/10/15 07:09:38, Yang wrote: This way we do not install them on the js ...
5 years, 2 months ago (2015-10-15 07:10:09 UTC) #2
adamk
lgtm Is ImportNow() new? I didn't see it when I added this hack originally.
5 years, 2 months ago (2015-10-15 07:20:24 UTC) #3
Yang
On 2015/10/15 07:20:24, adamk wrote: > lgtm > > Is ImportNow() new? I didn't see ...
5 years, 2 months ago (2015-10-15 07:22:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396323011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396323011/1
5 years, 2 months ago (2015-10-15 07:23:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/5300)
5 years, 2 months ago (2015-10-15 07:31:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396323011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396323011/20001
5 years, 2 months ago (2015-10-15 07:59:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 08:32:39 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 08:32:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6c945642c77fdebbe053e6f7fb29c07cda5806c
Cr-Commit-Position: refs/heads/master@{#31279}

Powered by Google App Engine
This is Rietveld 408576698