Run telemetry_gpu_unittests via isolate on "Window Tests" & "Mac tests" and trybot.

Run telemetry_gpu_unittests via isolate on "Windows Tests" & "Mac tests" and trybot.

BUG=507796
Committed: https://crrev.com/6c28e3046f6759b4e3de7f8bb190ef8eb1b25b8f
Cr-Commit-Position: refs/heads/master@{#353931}

[nednguyen, 2015-10-13 16:14:45]

nednguyen@google.com changed reviewers:
+ dpranke@chromium.org, kbr@chromium.org

[nednguyen, 2015-10-13 16:14:45]

Ken, Dirk: please help! The bot is complaining about telemetry_gpu_unittest not
defined, but isn't already defined in chrome/chrome_tests.gypi?

[Dirk Pranke, 2015-10-13 17:20:08]

On 2015/10/13 16:14:45, nednguyen (SLOW REVIEW ooo) wrote:
> Ken, Dirk: please help! The bot is complaining about telemetry_gpu_unittest
not
> defined, but isn't already defined in chrome/chrome_tests.gypi?

You have the telemetry_gpu_unittest* targets only defined inside an
'archive_gpu_tests==1' condition block, and it looks like those bots probably
don't have that GYP_DEFINE set. Either don't run the tests on those bots, move
the targets outside of the condition block, or set the GYP_DEFINE. I'm not sure
which of those is appropriate, that's probably something for you and kbr to
figure out.

[Ken Russell (switch to Gerrit), 2015-10-13 17:34:30]

On 2015/10/13 17:20:08, Dirk Pranke wrote:
> On 2015/10/13 16:14:45, nednguyen (SLOW REVIEW ooo) wrote:
> > Ken, Dirk: please help! The bot is complaining about telemetry_gpu_unittest
> not
> > defined, but isn't already defined in chrome/chrome_tests.gypi?
> 
> You have the telemetry_gpu_unittest* targets only defined inside an
> 'archive_gpu_tests==1' condition block, and it looks like those bots probably
> don't have that GYP_DEFINE set. Either don't run the tests on those bots, move
> the targets outside of the condition block, or set the GYP_DEFINE. I'm not
sure
> which of those is appropriate, that's probably something for you and kbr to
> figure out.

Yes, compilation of the majority of the GPU tests was made conditional because
these tests aren't run on the majority of Chromium's bots and there were
concerns about increasing the cycle time.

The telemetry_gpu_unittest_run target should be hoisted out of that conditional
block, since it'll be running on non-GPU bots.

[Ken Russell (switch to Gerrit), 2015-10-13 17:35:35]

On 2015/10/13 17:34:30, Ken Russell wrote:
> On 2015/10/13 17:20:08, Dirk Pranke wrote:
> > On 2015/10/13 16:14:45, nednguyen (SLOW REVIEW ooo) wrote:
> > > Ken, Dirk: please help! The bot is complaining about
telemetry_gpu_unittest
> > not
> > > defined, but isn't already defined in chrome/chrome_tests.gypi?
> > 
> > You have the telemetry_gpu_unittest* targets only defined inside an
> > 'archive_gpu_tests==1' condition block, and it looks like those bots
probably
> > don't have that GYP_DEFINE set. Either don't run the tests on those bots,
move
> > the targets outside of the condition block, or set the GYP_DEFINE. I'm not
> sure
> > which of those is appropriate, that's probably something for you and kbr to
> > figure out.
> 
> Yes, compilation of the majority of the GPU tests was made conditional because
> these tests aren't run on the majority of Chromium's bots and there were
> concerns about increasing the cycle time.
> 
> The telemetry_gpu_unittest_run target should be hoisted out of that
conditional
> block, since it'll be running on non-GPU bots.

BTW, I assume you've seen the xvfb import failure. Probably that script will
have to be included unconditionally in the isolate.

[nednguyen, 2015-10-13 20:39:19]

@Ken, the CL is ready for review

[nednguyen, 2015-10-13 20:40:38]

nednguyen@google.com changed reviewers:
+ maruel@chromium.org

[nednguyen, 2015-10-13 20:40:38]

+Marc for changes to testing/buildbot/ & chrome/chrome_tests.gypi

[Ken Russell (switch to Gerrit), 2015-10-13 20:56:46]

Superb. LGTM

[M-A Ruel, 2015-10-13 21:27:25]

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
File chrome/telemetry_gpu_unittests.isolate (right):

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
chrome/telemetry_gpu_unittests.isolate:16: '../testing/xvfb.py',
This must only be mapped when use_x11==1

[Ken Russell (switch to Gerrit), 2015-10-13 23:09:36]

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
File chrome/telemetry_gpu_unittests.isolate (right):

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
chrome/telemetry_gpu_unittests.isolate:16: '../testing/xvfb.py',
On 2015/10/13 21:27:25, M-A Ruel wrote:
> This must only be mapped when use_x11==1

Earlier try jobs which did this failed a module import. Either the Python file
always needs to be present (though it won't be invoked except on Linux) or
run_telemetry_as_googletest.py needs to be made more robust to avoid the xvfb
import on non-Linux platforms.

[M-A Ruel, 2015-10-14 00:25:50]

lgtm

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
File chrome/telemetry_gpu_unittests.isolate (right):

https://codereview.chromium.org/1396313005/diff/120001/chrome/telemetry_gpu_u...
chrome/telemetry_gpu_unittests.isolate:16: '../testing/xvfb.py',
On 2015/10/13 23:09:36, Ken Russell wrote:
> On 2015/10/13 21:27:25, M-A Ruel wrote:
> > This must only be mapped when use_x11==1
> 
> Earlier try jobs which did this failed a module import. Either the Python file
> always needs to be present (though it won't be invoked except on Linux) or
> run_telemetry_as_googletest.py needs to be made more robust to avoid the xvfb
> import on non-Linux platforms.

ok

[nednguyen, 2015-10-14 00:50:00]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-10-14 00:51:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396313005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396313005/120001

[commit-bot: I haz the power, 2015-10-14 00:58:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-14 00:59:23]

Patchset 7 (id:??) landed as
https://crrev.com/6c28e3046f6759b4e3de7f8bb190ef8eb1b25b8f
Cr-Commit-Position: refs/heads/master@{#353931}