Local omnibox treats navsuggest suggestions as queries.

chrome/browser/ui/search/instant_extended_browsertest.cc

Index: chrome/browser/ui/search/instant_extended_browsertest.cc
diff --git a/chrome/browser/ui/search/instant_extended_browsertest.cc b/chrome/browser/ui/search/instant_extended_browsertest.cc
index aebd5781a011eea21ac53c382e3438f9a6de9966..3a67d061ed60a5527393235323f0b58da0f9b7ac 100644
--- a/chrome/browser/ui/search/instant_extended_browsertest.cc
+++ b/chrome/browser/ui/search/instant_extended_browsertest.cc
@@ -7,6 +7,7 @@
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_controller.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
@@ -811,6 +812,65 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, ProcessIsolation) {
       active_tab->GetRenderProcessHost()->GetID()));
 }
 
+// Test that a search query will not be displayed for navsuggest queries.
+IN_PROC_BROWSER_TEST_F(
+    InstantExtendedTest, SearchQueryNotDisplayedForNavsuggest) {
+  ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
+
+  // Use only the local overlay.
+  instant()->SetInstantEnabled(true, true);
+
+  FocusOmniboxAndWaitForInstantExtendedSupport();
+  EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
+
+  SetOmniboxTextAndWaitForOverlayToShow("face");
+
+  // Add a navsuggest suggestion.
+  instant()->SetSuggestions(
+      instant()->overlay()->contents(),
+      std::vector<InstantSuggestion>(
+          1,
+          InstantSuggestion(ASCIIToUTF16("face"),

[sreeram, 2013/04/22 16:25:49]

Please set a valid URL (e.g.: "http://www.facemash.com/"). Otherwise, there's no
reason to expect that it will be accepted as a navsuggestion.

+                            INSTANT_COMPLETE_NOW,

[samarth, 2013/04/22 16:22:09]

If you're setting INSTANT_COMPLETE_NOW (aka doing a blue-highlight), shouldn't
this always be the top suggestion? Does this not work without the loop below?

+                            INSTANT_SUGGESTION_URL,
+                            ASCIIToUTF16("face"))));
+
+  // Create an event listener that opens the top suggestion in a new tab.
+  content::WebContents* overlay = instant()->GetOverlayContents();
+  int i = 0;
+  std::string nativeSuggestionString =
+      "chrome.embeddedSearch.searchBox.nativeSuggestions";
+  while (true) {
+    std::string nativeSuggestionsAtIndex =
+        nativeSuggestionString + "[" + base::IntToString(i) + "]";
+
+    // Break if this nativeSuggestions index doesn't exist.
+    bool indexExists;
+    EXPECT_TRUE(GetBoolFromJS(overlay, nativeSuggestionString +
+        ".hasOwnProperty('" + base::IntToString(i) + "')", &indexExists));
+    if (!indexExists)
+      break;
+
+    bool isSearchPropertyExists;
+    EXPECT_TRUE(GetBoolFromJS(overlay, nativeSuggestionsAtIndex +
+        ".hasOwnProperty('is_search')", &isSearchPropertyExists));
+
+    // Verify that if this is a search suggestion the type is not navsuggest.
+    if (isSearchPropertyExists) {
+      bool is_search;
+      EXPECT_TRUE(GetBoolFromJS(
+          overlay, nativeSuggestionsAtIndex + ".is_search", &is_search));
+
+      std::string type;
+      EXPECT_TRUE(
+          GetStringFromJS(overlay, nativeSuggestionsAtIndex + ".type", &type));
+
+      EXPECT_FALSE(is_search && type == "navsuggest");
+    }
+    ++i;
+  }

[sreeram, 2013/04/22 16:25:49]

I don't understand why you need this loop at all. A navsuggestion will be ranked
at the top, since there are no history matches to outscore it. So, all you have
to do is check that the top nativesuggestion is the expected navsuggestion, and
that it doesn't have is_query set. I mentioned this way back in comment #6 on
the review thread:
  GetBoolFromJS(nativeSuggestions[0].is_search, &value);

At line 838, after setting the navsuggestion, you might need to wait for the
autocomplete results to be sent. See this pattern elsewhere in this file:
  // Wait for all autocomplete results to be sent to the page
  while (!omnibox()->model()->autocomplete_controller()->done()) {
    ...
  }

If that doesn't work, please explain why.

[dougw, 2013/04/26 18:38:54]

A search-what-you-typed suggestion appears above the navsuggest suggestion. I
could modify to specifically check the second suggestion, but the loop also
helps to future-proof the test.

One other thing: The test doesn't fail if a navsuggest suggestion is not
encountered. I assume this is the preferred behavior.


On 2013/04/22 16:25:49, sreeram wrote:

[samarth, 2013/04/29 17:49:20]

I think that's because the suggestions aren't in sorted order by default.  If
you look at the debug output, it's something like:

 AutocompleteResults:
     1300 search-what-you-typed Search
https://127.0.0.1:57692/files/instant_extended.html?strk=1&q=face '' 'face' 5
     1301 navsuggest Search http://facemash.com/ '' '' 1

So the navsuggest is indeed ranking above the SWYT suggestion. You should be
able to
1) sort the nativeSuggestions array by score in JS
2) ASSERT that the top suggestion is a navsuggest
3) EXPECT that it is not a search suggestion
That's not so great because then it's possible for this behavior to break
without this test failing. If this test becomes no longer sufficient in the
future, it's best to know earlier rather than later.

[dougw, 2013/04/29 21:57:07]

Done.

+}
+
 // Verification of fix for BUG=176365.  Ensure that each Instant WebContents in
 // a tab uses a new BrowsingInstance, to avoid conflicts in the
 // NavigationController.