Local omnibox treats navsuggest suggestions as queries.

chrome/browser/ui/search/instant_extended_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_controller.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/autocomplete_provider.h"
 #include "chrome/browser/autocomplete/autocomplete_result.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
@@ skipping 784 matching lines @@
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(instant_service->IsInstantProcess(
       active_tab->GetRenderProcessHost()->GetID()));
 
   // Navigating elsewhere should not use the Instant render process.
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIAboutURL));
   EXPECT_FALSE(instant_service->IsInstantProcess(
       active_tab->GetRenderProcessHost()->GetID()));
 }
 
+// Test that a search query will not be displayed for navsuggest queries.
+IN_PROC_BROWSER_TEST_F(
+    InstantExtendedTest, SearchQueryNotDisplayedForNavsuggest) {
+  ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
+  FocusOmniboxAndWaitForInstantExtendedSupport();
+  EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
+
+  // Typing in the omnibox should show the overlay.
+  SetOmniboxTextAndWaitForOverlayToShow("cnn.com");
+
+  // Create an event listener that opens the top suggestion in a new tab.
+  content::WebContents* overlay = instant()->GetOverlayContents();
+  int i = 0;
+  while (true) {
+    std::string nativeSuggestionsAtIndex = 
+        "chrome.embeddedSearch.searchBox.nativeSuggestions[" +
+        base::IntToString(i) + "]";
+
+    if (!ExecuteScript(nativeSuggestionsAtIndex))
+      break;
+
+    if (ExecuteScript(nativeSuggestionsAtIndex+".is_search")) {
+      bool is_search;
+      EXPECT_TRUE(GetBoolFromJS(
+          overlay, nativeSuggestionsAtIndex+".is_search", &is_search));
+
+      std::string type;
+      EXPECT_TRUE(
+          GetStringFromJS(overlay, nativeSuggestionsAtIndex+".type", &type));
+
+      EXPECT_FALSE(is_search && type == "navsuggest");
+    }
+
+    ++i;
+  }
+}

[sreeram, 2013/04/18 17:51:40]

This test uses the server overlay. We don't send any SearchProvider results to a
server overlay, so I don't know how you'd expect any of this to work.

You should cause the local overlay to be used (for example, by calling
SetInstantEnabled() with the right values), and then test that.

[dougw, 2013/04/19 01:11:09]

Done.

+
 // Verification of fix for BUG=176365.  Ensure that each Instant WebContents in
 // a tab uses a new BrowsingInstance, to avoid conflicts in the
 // NavigationController.
 // Flaky: http://crbug.com/177516
 IN_PROC_BROWSER_TEST_F(InstantExtendedTest, DISABLED_UnrelatedSiteInstance) {
   // Setup Instant.
   ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
   FocusOmniboxAndWaitForInstantExtendedSupport();
 
   // Check that the uncommited ntp page and uncommited overlay have unrelated
@@ skipping 836 matching lines @@
   EXPECT_EQ(ASCIIToUTF16(""), GetGrayText());
 
   // Make the page send an unexpected suggestion.
   EXPECT_TRUE(ExecuteScript("suggestion = 'chippies';"
                             "handleOnChange();"));
 
   // Verify that the suggestion is ignored.
   EXPECT_EQ("result 1", GetOmniboxText());
   EXPECT_EQ(ASCIIToUTF16(""), GetGrayText());
 }