Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3661)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 13963004: Extract common OOBE controller code from oobe.js/login.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
index d443b755b3ef16534d65f157f9880fe764129dbf..86294ca7f4eb84b7e70f332862243cccfbc4ed5b 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
@@ -57,6 +57,7 @@ const char kEnterpriseEnrollmentGaiaLoginPath[] = "gaialogin";
const char kStringsJSPath[] = "strings.js";
const char kLoginJSPath[] = "login.js";
+const char kOobeCommonJSPath[] = "oobe_common.js";
dzhioev (left Google) 2013/04/16 10:47:48 I think it is not needed.
dconnelly 2013/04/16 11:11:22 Done.
const char kOobeJSPath[] = "oobe.js";
const char kDemoUserLoginJSPath[] = "demo_user_login.js";
@@ -93,6 +94,8 @@ content::WebUIDataSource* CreateOobeUIDataSource(
}
source->SetDefaultResource(IDR_OOBE_HTML);
+ source->AddResourcePath(kOobeCommonJSPath,
dzhioev (left Google) 2013/04/16 10:47:48 Not needed to.
dconnelly 2013/04/16 11:11:22 Done.
+ IDR_OOBE_COMMON_JS);
source->AddResourcePath(kOobeJSPath,
IDR_OOBE_JS);
source->AddResourcePath(kLoginPath,

Powered by Google App Engine
This is Rietveld 408576698