Extract common OOBE controller code from oobe.js/login.js.

Extract common OOBE controller code from oobe.js/login.js.

BUG=232048

[dzhioev (left Google), 2013-04-16 10:47:48]

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/browser_res...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/browser_res...
chrome/browser/browser_resources.grd:54: <structure name="IDR_OOBE_COMMON_JS"
file="resources\chromeos\login\oobe_common.js" flattenhtml="true"
type="chrome_html" />
Do we need this declaration here? I thought preprocessor can handle included
file automatically. For example all the screen_*.{html,js,css} not declared
here.

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:60: const char
kOobeCommonJSPath[] = "oobe_common.js";
I think it is not needed.

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:97:
source->AddResourcePath(kOobeCommonJSPath,
Not needed to.

[dconnelly, 2013-04-16 11:11:22]

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/browser_res...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/browser_res...
chrome/browser/browser_resources.grd:54: <structure name="IDR_OOBE_COMMON_JS"
file="resources\chromeos\login\oobe_common.js" flattenhtml="true"
type="chrome_html" />
On 2013/04/16 10:47:48, dzhioev wrote:
> Do we need this declaration here? I thought preprocessor can handle included
> file automatically. For example all the screen_*.{html,js,css} not declared
> here.

Cool. I didn't know it did that, but it makes sense.

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:60: const char
kOobeCommonJSPath[] = "oobe_common.js";
On 2013/04/16 10:47:48, dzhioev wrote:
> I think it is not needed.

Done.

https://codereview.chromium.org/13963004/diff/2001/chrome/browser/ui/webui/ch...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:97:
source->AddResourcePath(kOobeCommonJSPath,
On 2013/04/16 10:47:48, dzhioev wrote:
> Not needed to.

Done.

[Denis Kuznetsov (DE-MUC), 2013-04-16 11:29:19]

lgtm

[Nikita (slow), 2013-04-16 13:01:54]

lgtm

https://codereview.chromium.org/13963004/diff/8/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe_common.js (right):

https://codereview.chromium.org/13963004/diff/8/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe_common.js:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
nit: Makes sense to call this file login_common.js

[Nikita (slow), 2013-04-16 13:08:23]

I was trying to apply that patch locally to send that to cros_* trybots but
seems that patch needs rebase.

[dzhioev (left Google), 2013-04-16 13:13:28]

On 2013/04/16 13:08:23, Nikita Kostylev wrote:
> I was trying to apply that patch locally to send that to cros_* trybots but
> seems that patch needs rebase.

lgtm

[dconnelly, 2013-04-16 14:19:38]

Rebased.

https://codereview.chromium.org/13963004/diff/8/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/oobe_common.js (right):

https://codereview.chromium.org/13963004/diff/8/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/oobe_common.js:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
On 2013/04/16 13:01:55, Nikita Kostylev wrote:
> nit: Makes sense to call this file login_common.js

Done.

[Nikita (slow), 2013-04-16 20:18:15]

I've created metabug for this change: http://crbug.com/232048

[dconnelly, 2013-04-17 10:30:05]

On 2013/04/16 20:18:15, Nikita Kostylev wrote:
> I've created metabug for this change: http://crbug.com/232048

Nikita, do you mind dcommit-ing this?

[Nikita (slow), 2013-04-17 12:38:48]

http://src.chromium.org/viewvc/chrome?revision=194581

[Nikita (slow), 2013-04-17 12:38:49]

http://src.chromium.org/viewvc/chrome?revision=194581