Add standard policy provider tests for PReg policy reading.

Add standard policy provider tests for PReg policy reading.

This wires up the standard ConfigurationPolicyProviderTest suite with a
PolicyLoaderWin that is reading policy from GPO PReg files.

BUG=chromium:186445
TEST=unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194549

[Mattias Nissler (ping if slow), 2013-04-16 09:05:18]

Here are a couple more tests, please review.

[Joao da Silva, 2013-04-16 10:46:25]

lgtm with nits. Why isn't the ScopedTempDir cleaned up?

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_win.h (right):

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win.h:18: #include "base/files/file_path.h"
nit: order

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:13: #include <cstring>
nit: order

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:18: #include
"base/strings/string_number_conversions.h"
nit: already included

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:20: #include
"base/sys_byteorder.h"
nit: order

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:25: #include
"base/files/scoped_temp_dir.h"
nit: order

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:30: #include
"chrome/browser/policy/preg_parser_win.h"
nit: order

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:246: explicit
RegistryTestHarness(HKEY hive, PolicyScope scope);
Doesn't have to be explicit.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:296: explicit
PRegTestHarness();
Doesn't have to be explicit.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:359: PolicyScope scope_;
This isn't used.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:515: PGROUP_POLICY_OBJECT*
gpo_list) {
nit: indent

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:538: temp_dir_.Take();
Why? Did you intend to remove this before uploading?

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:690:
std::back_inserter(data), std::ptr_fun(base::ByteSwapToLE16));
#include <functional>

[Mattias Nissler (ping if slow), 2013-04-16 13:00:05]

Thanks for the review. Now you know how much I've come to  depend on automatic
header sorting, this is what happens if it's off accidentally ;)

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_win.h (right):

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win.h:18: #include "base/files/file_path.h"
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: order

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:13: #include <cstring>
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: order

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:18: #include
"base/strings/string_number_conversions.h"
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: already included

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:20: #include
"base/sys_byteorder.h"
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: order

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:25: #include
"base/files/scoped_temp_dir.h"
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: order

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:30: #include
"chrome/browser/policy/preg_parser_win.h"
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: order

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:246: explicit
RegistryTestHarness(HKEY hive, PolicyScope scope);
On 2013/04/16 10:46:25, Joao da Silva wrote:
> Doesn't have to be explicit.

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:296: explicit
PRegTestHarness();
On 2013/04/16 10:46:25, Joao da Silva wrote:
> Doesn't have to be explicit.

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:359: PolicyScope scope_;
On 2013/04/16 10:46:25, Joao da Silva wrote:
> This isn't used.

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:515: PGROUP_POLICY_OBJECT*
gpo_list) {
On 2013/04/16 10:46:25, Joao da Silva wrote:
> nit: indent

Done.

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:538: temp_dir_.Take();
On 2013/04/16 10:46:25, Joao da Silva wrote:
> Why? Did you intend to remove this before uploading?

This happens if you only get to work on a given thing for a couple minutes. I
guess I should write down notes :)

https://codereview.chromium.org/13963003/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_win_unittest.cc:690:
std::back_inserter(data), std::ptr_fun(base::ByteSwapToLE16));
On 2013/04/16 10:46:25, Joao da Silva wrote:
> #include <functional>

Done.

[Joao da Silva, 2013-04-16 13:05:14]

Looks good to me after the last changes. Can you run this through the try bots
before landing?

[Mattias Nissler (ping if slow), 2013-04-16 13:08:39]

On 2013/04/16 13:05:14, Joao da Silva wrote:
> Looks good to me after the last changes. Can you run this through the try bots
> before landing?

Goes without saying.

[Mattias Nissler (ping if slow), 2013-04-17 09:16:39]

Committed patchset #4 manually as r194549 (presubmit successful).