Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1396293003: Use RenderFrameHost::AddMessageToConsole for app banner debug logging. (Closed)

Created:
5 years, 2 months ago by dominickn
Modified:
5 years, 2 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use RenderFrameHost::AddMessageToConsole for app banner debug logging. This CL replaces the custom IPC message used by the app banner debug log to add a message to the devtools console with the existing AddMessageToConsole method in RenderFrameHost. This allows boilerplate IPC scaffolding to be removed. BUG=542382 R=mlamouri@chromium.org,benwells Committed: https://crrev.com/2402cc50e8c7d7c9ccca176dc2fc96a7a955a915 Cr-Commit-Position: refs/heads/master@{#353879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M chrome/browser/banners/app_banner_debug_log.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
dominickn
PTAL, thanks!
5 years, 2 months ago (2015-10-12 23:35:22 UTC) #1
benwells
lgtm.
5 years, 2 months ago (2015-10-13 04:17:25 UTC) #2
dominickn
+palmer: please review common/render_messages.h +jochen: please review chrome/renderer/ Thanks!
5 years, 2 months ago (2015-10-13 04:26:40 UTC) #4
mlamouri (slow - plz ping)
lgtm. Thanks for doing this! :)
5 years, 2 months ago (2015-10-13 09:27:24 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-13 15:55:07 UTC) #6
palmer
LGTM.
5 years, 2 months ago (2015-10-13 17:10:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396293003/1
5 years, 2 months ago (2015-10-13 22:13:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 22:39:22 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:40:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2402cc50e8c7d7c9ccca176dc2fc96a7a955a915
Cr-Commit-Position: refs/heads/master@{#353879}

Powered by Google App Engine
This is Rietveld 408576698