fpdfsdk/include/fsdk_define.h - Issue 1396283006: Fix layering violation in CPDF_Document::FromFPDFDocument().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fsdk_define.h

Issue 1396283006: Fix layering violation in CPDF_Document::FromFPDFDocument(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/fsdk_define.h

diff --git a/fpdfsdk/include/fsdk_define.h b/fpdfsdk/include/fsdk_define.h

index 12e3f2732dee8d8ffebcc21ef2a6c182f1890da2..89106288913d3edf40b53094a1282c6130c66399 100644

--- a/fpdfsdk/include/fsdk_define.h

+++ b/fpdfsdk/include/fsdk_define.h

@@ -56,6 +56,9 @@ class CPDF_CustomAccess final : public IFX_FileRead {

FPDF_FILEACCESS m_FileAccess;

};

+// Conversions from FPDF_ types.

+CPDF_Document* CPDFDocumentFromFPDFDocument(FPDF_DOCUMENT doc);

Tom Sepez 2015/10/15 17:45:56 Should this be an inline? Its just a cast or a ptr

Lei Zhang 2015/10/15 21:50:23 Will it actually make a measurable difference? Up

void DropContext(void* data);

void FSDK_SetSandBoxPolicy(FPDF_DWORD policy, FPDF_BOOL enable);

FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy);

« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp ('k') | fpdfsdk/src/fpdf_dataavail.cpp » ('j') | no next file with comments »